Closed Bug 1489510 Opened Last year Closed Last year

Fix null check in vm/TraceLoggingGraph.cpp

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: rbartlensky, Assigned: rbartlensky)

References

(Blocks 1 open bug)

Details

(Whiteboard: [CID 1438852])

Attachments

(1 file)

https://searchfox.org/mozilla-central/source/js/src/vm/TraceLoggingGraph.cpp#544 it should check if it is null, not for not null. Even the comment suggests that the line is incorrect.

Also, `treefile` is used on 547 as an argument to `fseek`. Handling a null-pointer might cause problems.
Coverity found that a null-pointer is passed to fseek,
because the previous condition does not check for null.
Comment on attachment 9007231 [details]
Bug 1489510: Add check for null in vm/TraceLoggingGraph.cpp.

Steve Fink [:sfink] [:s:] has approved the revision.
Attachment #9007231 - Flags: review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3673bb1b3e56
Add check for null in vm/TraceLoggingGraph.cpp. r=sfink
https://hg.mozilla.org/mozilla-central/rev/3673bb1b3e56
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.