Closed Bug 1489510 Opened Last year Closed Last year
Fix null check in vm/Trace
Logging Graph .cpp
46 bytes, text/x-phabricator-request
|Details | Review|
https://searchfox.org/mozilla-central/source/js/src/vm/TraceLoggingGraph.cpp#544 it should check if it is null, not for not null. Even the comment suggests that the line is incorrect. Also, `treefile` is used on 547 as an argument to `fseek`. Handling a null-pointer might cause problems.
Coverity found that a null-pointer is passed to fseek, because the previous condition does not check for null.
Comment on attachment 9007231 [details] Bug 1489510: Add check for null in vm/TraceLoggingGraph.cpp. Steve Fink [:sfink] [:s:] has approved the revision.
Attachment #9007231 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/3673bb1b3e56 Add check for null in vm/TraceLoggingGraph.cpp. r=sfink
You need to log in before you can comment on or make changes to this bug.