Closed Bug 1489519 Opened 7 years ago Closed 6 years ago

[tc-tools] allow sorting worker-types by name in the worker-types list view

Categories

(Taskcluster :: UI, enhancement)

Product:
Taskcluster
Component:
UI
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: soundharya, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: taskcluster-web)

Right now, you can sort by None (random order) or by number of pending, but not by name. Let's add an option to sort by name. Example of the view: https://tools.taskcluster.net/provisioners/aws-provisioner-v1/worker-types
We can sort the list by name by default instead of the random order.
Keywords: good-first-bug
Hi, Can I work on this bug?
Flags: needinfo?(dustin)
Definitely!
Assignee: nobody → soundharyabharatiya
Thanks, Hassan! Can you please provide some of the initial instructions to start with?
When a user first loads https://tools.taskcluster.net/provisioners/aws-provisioner-v1/worker-types, we want the worker-types to be sorted alphabetically by name. A user can then modify the sorting via the "Order By" dropdown. The code for this will be in https://github.com/taskcluster/taskcluster-tools/tree/master/src/views/WorkerTypes. Good luck!
Thank you. I will start working on this and get back to you, if information is needed!
Flags: needinfo?(dustin)
I have changed the "None" to "Name" in https://tools.taskcluster.net/provisioners/aws-provisioner-v1/worker-types by changing the code in OrderByDropdown.jsx for adding the sorting by name in worker-types. Screenshot: https://imgur.com/a/EQfnOLm . Now, how should I proceed now for adding the sorting features and where should I change the code?
The next step is to open a pull-request and then we can take it from there :)
Sure. I will do that. So, do I need to create the separate branch from master and have to create the PR?
That's right!
Okay. Thanks!
Submitted an PR, please let me know how to proceed from there. https://github.com/taskcluster/taskcluster-tools/pull/572
Hi, Can someone let me know, how should I proceed next? I am kinda stuck with codebase. Thanks!
Can you ask a more detailed question? Last I heard, you were going to modify handleProvisionerSelect. Did that not work?
This has been taken care of in tc-web[1]. [1] https://taskcluster-web.netlify.com/provisioners/aws-provisioner-v1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: taskcluster-web
Component: Tools → UI and Tools
You need to log in before you can comment on or make changes to this bug.