1489537 - WebRTC appears to reuse connections across Containers/FPI/PBM?

Status: RESOLVED INVALID

(Core :: WebRTC: Networking, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until April)]

While spelunking around in https://searchfox.org/mozilla-central/source/media/webrtc/trunk/webrtc/base/socketpool.cc and related, it seems like WebRTC has its own SocketPool and will reuse connections if it is able to do so.

However, it operates on SocketAddress and doesn't seem to have any notion of either OriginAttributes or Private Browsing Mode.

If this code is used (and I am not certain that it is) it seems like it would violate separation of PBM, Containers, and First Party Isolation.

Comment 1

[Dan Minor [:dminor]]

We don't build or use socketpool.cc. We only build and use the code that is part of rtc_base_approved [1], socketpool.cc is part of rtc_base. Please have a look at the list of files in rtc_base_approved and let me know if there is anything of concern there.

[1] https://searchfox.org/mozilla-central/rev/6201a9e0067cf6af118c6a99ae9314b8ceb2c4d5/media/webrtc/trunk/webrtc/base/BUILD.gn#101

Comment 2

[Tom Ritter [:tjr] (OOTO until April)]

Thanks Dan!