All statusbar separators are missing one pixel at the bottom on Windows 10

RESOLVED FIXED in Thunderbird 64.0

Status

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: jorgk, Assigned: Paenglab)

Tracking

Thunderbird 64.0

Thunderbird Tracking Flags

(thunderbird_esr6062+ fixed, thunderbird63 fixed, thunderbird64 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Apparently that's where an invisible border is drawn. It's visible on Windows 7, I'm told ;-)
Posted patch statusbar.patch (obsolete) — Splinter Review
How about this? Only Classic and HC themes use the statusbarpanel appearance.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9007455 - Flags: review?(jorgk)
Yes, this is going in the right direction. But the vertical separator now doesn't have the same shade of grey as the horizontal line above it.

Also, on Windows 10, can I test Classic and HC (High Contrast)? Win10's HC themes seemed to behave like "normal" Win10 themes, they had the missing pixel and now it's gone. Are you referring to Win 7 Classic and HC?
(In reply to Jorg K (GMT+2) from comment #2)
> Yes, this is going in the right direction. But the vertical separator now
> doesn't have the same shade of grey as the horizontal line above it.

There is no perfect match with system colors. To match I'd need a custom color.

> Also, on Windows 10, can I test Classic and HC (High Contrast)? Win10's HC
> themes seemed to behave like "normal" Win10 themes, they had the missing
> pixel and now it's gone. Are you referring to Win 7 Classic and HC?

Classic is Win7. High Contrast are on all platforms.
Comment on attachment 9007455 [details] [diff] [review]
statusbar.patch

(In reply to Richard Marti (:Paenglab) from comment #3)
> There is no perfect match with system colors. To match I'd need a custom
> color.
Sorry for the delay, I was shuffling some ESR 60 patches around. I understand this now. It the ThreeDLightShadow in statusbarpanel. I think ThreeDShadow looks a little better, although it's clearly darker.

Looking at the Windows 7 screenshot you sent via PM, the horizontal line is darker than the vertical line, so the patch is possibly OK.

Tested with Windows 10 "normal" and all the HC themes if offers. Can't test Win7. Is that unchanged? As this for Win7?
+@media (-moz-windows-default-theme: 0) {
+  statusbarpanel:not(:-moz-lwtheme) {
+    -moz-appearance: statusbarpanel;
+  }
+}

Actually, I also tested with a WE theme. That can override the horizontal colour, but not the vertical one? So it didn't look good.
(In reply to Jorg K (GMT+2) from comment #4)
> Comment on attachment 9007455 [details] [diff] [review]
> statusbar.patch
> 
> Tested with Windows 10 "normal" and all the HC themes if offers. Can't test
> Win7. Is that unchanged? As this for Win7?
> +@media (-moz-windows-default-theme: 0) {
> +  statusbarpanel:not(:-moz-lwtheme) {
> +    -moz-appearance: statusbarpanel;
> +  }
> +}

Win7 default themes, Basic and Aero use the new styles -> no white borders around the statusbarpanels. They look now like on Win10.

I changed the media query to @media (-moz-windows-classic) to be more descriptive as it's more or less the same. Both apply to Win7 Classic and HC.

> Actually, I also tested with a WE theme. That can override the horizontal
> colour, but not the vertical one? So it didn't look good.

I thought also about this and discarded it. But now I implemented it a bit different for dark themes as the separator wasn't visible with using the default --tabs-border-color. So I added a new colour for the statusbar border when a dark theme is used. This adds now a visible top border to the statusbar. Now it's almost not visible with the light content colours above it but I'm on theming the folder pane where it is visible then.
Attachment #9007548 - Flags: review?(jorgk)
Attachment #9007455 - Attachment is obsolete: true
Attachment #9007455 - Flags: review?(jorgk)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1c7fb9ee2572
Style the statusbar so that the separators touch the bottom. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Comment on attachment 9007548 [details] [diff] [review]
statusbar.patch

Yes, that works fine.
Attachment #9007548 - Flags: review?(jorgk) → review+
Do you want this for ESR too? No change in file, only had to rebase it.
Attachment #9007553 - Flags: approval-comm-esr60?
Comment on attachment 9007548 [details] [diff] [review]
statusbar.patch

Maybe for beta too.
Attachment #9007548 - Flags: approval-comm-beta?
Comment on attachment 9007548 [details] [diff] [review]
statusbar.patch

Sure.
Attachment #9007548 - Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 9007553 [details] [diff] [review]
statusbar-ESR.patch

Yes, I want it, but since the pixel has been missing at least since TB 52, there's no huge hurry. Wayne hates last minute uplifts, and I'm a little worried that I can't test it on Win7. Sure, it's CSS only with no "position: relative" ;-)
Target Milestone: --- → Thunderbird 64.0
You need to log in before you can comment on or make changes to this bug.