148959 - Disabled "Edit/delete host" and "Edit/delete domain"

Status: RESOLVED INVALID

(Core Graveyard :: History: Global, defect)

Description

[moz]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0rc3) Gecko/20020523
BuildID:    2002052306

Reproducible: Always
Steps to Reproduce:
1. See historial. Click View / Group by / None
2. Close historial. Open it.
3. You have the first row selected, "delete host" and "delete domain" are disabled

Expected Results:  "delete host" and "delete domain" should be enabled, as you have one selected.

Comment 1

[moz]

I mean, "Edit/delete host" and "Edit/delete domain".

Comment 2

[Steve Simms]

"Delete host" and "Delete domain" are no longer options in the History viewer --
there's only "Delete" now.

Therefore, this bug is no longer relevant.

Comment 3

[moz]

> "Delete host" and "Delete domain" are no longer options in the History viewer --
The options now have the form: "Delete all from www.example.com" and "Delete entire domain example.com". But the user interface keeps being not consistent and so the options sometimes appear and sometimes not, this bug should can not be marked as "invalid" so easily.

For example:

1. See history. Click View / Group by / None
2. Close history. Open it.
3. Now you have the first row selected, click on "Edit", you can see you only have the option "delete" to delete from history. Close history.
4. Move down with the cursors, move up.
3. You have the first row selected (as before), click on "Edit", now two options appear ("delete all from www.example.com" and "Delete entire domain example.com"). They should have been there from the start if it behaved correctly.

Comment 4

[Steve Simms]

You're absolutely right -- I misunderstood your earlier comment because I didn't
have the "delete host" and "delete domain" options in my Edit menu (grayed out
or otherwise).  Thanks for the more detailed instructions.

This also happens on Linux (2003021008).

Confirming.

The discussion on bug 81065 could be relevant.

Comment 5

[moz]

> Thanks for the more detailed instructions.
Thanks to all of you for making Mozilla a better product ;-)

Comment 6

[Robert Turnbull]

Build ID: 20033102805

Mozila 1.6a

Delete host and delete domain are greyed out and non-functional.

To reproduce:

hit CTRL-H

Select a history entry

Select Edit

Only greyed out deletion options appear.

Comment 7

[Robert Turnbull]

That was 1.6a linux. The plain Delete option is still available. Only the host
and domain options are greyed out.

Comment 8

[Robert Turnbull]

Also messed up in the same way for Mozilla 1.6a on Win2k.

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 225134 has been marked as a duplicate of this bug. ***

Comment 10

[Andreas Kunz]

This is almost fixed (I think bug 227053 did it).
When grouping is "none" you still have to select an item manually for making it
work; the first item is selected by default but does not offer these delete options.
When grouping is "Site" or "Day" you have to do a manual selection anyway, so
these modes don't show this bug.
This may well have the same cause as bug 215590.

Comment 11

[Andreas Kunz]

In historyOnSelect:
var url = rowIsContainer ? "" :
gHistoryTree.treeBoxObject.view.getCellText(currentIndex, "URL");

getCellText returns "" the first time it is called for Index 0. Later it does
return the URL for index 0 correctly...