Closed
Bug 1489601
Opened 7 years ago
Closed 7 years ago
fix thinko in AtomicOperations-arm64-msvc.h
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
893 bytes,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
Made a small mistake when applying some review feedback.
|
Assignee | |
Comment 1•7 years ago
|
||
I apparently thought blindly applying review feedback without compiling
everything would be a good idea. Turns out MemoryBarrier isn't defined where
we need it to be to use it in this file, and trying to include in leads us into
Windows include issues. So we go with the quick-and-dirty approach of using
the expansion of the macro instead.
(The constant is to specify MBReqDomainFullSystem, MBReqTypes_All to `dmb`, if
you have your ARM64ARM handy.)
Attachment #9007321 -
Flags: review?(lhansen)
|
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9007321 [details] [diff] [review]
fix thinko in AtomicOperations-arm64-msvc.h
Review of attachment 9007321 [details] [diff] [review]:
-----------------------------------------------------------------
Yeah, ship it.
Attachment #9007321 -
Flags: review?(lhansen) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cef9a1ef6b54
fix thinko in AtomicOperations-arm64-msvc.h; r=lth
|
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•