Closed Bug 1489629 Opened 2 years ago Closed 2 years ago

Adjust the size of the error images, sizing and position of text, and add footer branding to more views

Categories

(Firefox :: WebPayments UI, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 64
Tracking Status
firefox64 --- verified

People

(Reporter: jaws, Assigned: jaws)

Details

(Whiteboard: [webpayments-reserve])

Attachments

(1 file)

From https://bugzilla.mozilla.org/show_bug.cgi?id=1487395#c8,
> The error strings, as well as the "Close" button, are looking good on both
> the Payment Timeout and Failure screen.
> However, I would like to point out that the size of the Images, as well as
> the font of the strings, are different compared to the spec. Check:
> https://imgur.com/4Lbrlrt
> Also, the "Nightly Checkout" is missing from the footer. Should all this be
> considered as concerns now or it will be handled later?
Flags: qe-verify?
Whiteboard: [webpayments] → [webpayments-reserve]
Comment on attachment 9007362 [details]
Bug 1489629 - Adjust the size of the error images, sizing and position of text, and add footer branding to the error pages. r?sfoster

Sam Foster [:sfoster] has approved the revision.
Attachment #9007362 - Flags: review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b24a0fca9b7
Adjust the size of the error images, sizing and position of text, and add footer branding to the error pages. r=sfoster
https://hg.mozilla.org/mozilla-central/rev/2b24a0fca9b7
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Flags: qe-verify? → qe-verify+
QA Contact: hani.yacoub
Hi Jared,

The error images, sizing and the position of the text looks good now. However, on the payment Failure screen I have the feeling that is not centered correctly, check out: https://imgur.com/EpmKb4x
Flags: needinfo?(jaws)
Hi Timea,

That error message is centered as good as we can do based on the long domain name which is wrapping to the next line. The text in the suggestions below the heading are all one line and are not wrapping too soon.
Flags: needinfo?(jaws)
Thanks Jared,

Based on Comment 5 and Comment 6 I will close this issue as Verified - Fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.