Adjust the size of the error images, sizing and position of text, and add footer branding to more views
VERIFIED
FIXED
in Firefox 64
Status
()
People
(Reporter: jaws, Assigned: jaws)
Tracking
Firefox Tracking Flags
(firefox64 verified)
Details
(Whiteboard: [webpayments-reserve])
Attachments
(1 attachment)
From https://bugzilla.mozilla.org/show_bug.cgi?id=1487395#c8, > The error strings, as well as the "Close" button, are looking good on both > the Payment Timeout and Failure screen. > However, I would like to point out that the size of the Images, as well as > the font of the strings, are different compared to the spec. Check: > https://imgur.com/4Lbrlrt > Also, the "Nightly Checkout" is missing from the footer. Should all this be > considered as concerns now or it will be handled later?
|
||
Updated•8 months ago
|
Flags: qe-verify?
Whiteboard: [webpayments] → [webpayments-reserve]
|
(Assignee) | |
Comment 1•8 months ago
|
||
|
||
Comment 2•8 months ago
|
||
Comment on attachment 9007362 [details] Bug 1489629 - Adjust the size of the error images, sizing and position of text, and add footer branding to the error pages. r?sfoster Sam Foster [:sfoster] has approved the revision.
Attachment #9007362 -
Flags: review+
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b24a0fca9b7 Adjust the size of the error images, sizing and position of text, and add footer branding to the error pages. r=sfoster
|
||
Comment 4•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2b24a0fca9b7
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
|
|
||
Updated•7 months ago
|
Flags: qe-verify? → qe-verify+
QA Contact: hani.yacoub
|
||
Comment 5•7 months ago
|
||
Hi Jared, The error images, sizing and the position of the text looks good now. However, on the payment Failure screen I have the feeling that is not centered correctly, check out: https://imgur.com/EpmKb4x
Flags: needinfo?(jaws)
|
|
(Assignee) | |
Comment 6•7 months ago
|
||
Hi Timea, That error message is centered as good as we can do based on the long domain name which is wrapping to the next line. The text in the suggestions below the heading are all one line and are not wrapping too soon.
Flags: needinfo?(jaws)
|
|
||
Comment 7•7 months ago
|
||
Thanks Jared, Based on Comment 5 and Comment 6 I will close this issue as Verified - Fixed.
You need to log in
before you can comment on or make changes to this bug.
Description
•