Closed Bug 1489657 Opened Last year Closed Last year

Baseline Inspector may compute the wrong return type of a URSH

Categories

(Core :: JavaScript Engine: JIT, enhancement, trivial)

enhancement
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mgaudet, Assigned: mgaudet)

Details

Attachments

(1 file)

In the Baseline Inspector we assume a URSH IC always returns an Int32. 

However this is not the case: It may under some circumstances return a double.

I don't think this bug would be triggered right now, because I don't think the query is asked, but should be correct for completeness sake.
Comment on attachment 9007377 [details]
Bug 1489657 - Correctly compute return type of CacheIR URSH IC r=tcampbell

Ted Campbell [:tcampbell] has approved the revision.
Attachment #9007377 - Flags: review+
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a5279d80ab0
Correctly compute return type of CacheIR URSH IC r=tcampbell
https://hg.mozilla.org/mozilla-central/rev/0a5279d80ab0
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec95e97c09f4
Correct whitespace in expression r=me (trivial) DONTBUILD
You need to log in before you can comment on or make changes to this bug.