Closed
Bug 1489671
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 12901 - Loosen timing expectation in IntersectionObserver WPTs
Categories
(Core :: Layout, enhancement, P4)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 12901 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/12901
Details from upstream follow.
Ali Juma <ajuma@chromium.org> wrote:
> Loosen timing expectation in IntersectionObserver WPTs
>
> IntersectionObserver WPTs expect that intersection observations are
> delivered withing two step_timeouts of requestAnimationFrame. This
> expectation holds in Blink, but doesn't necessarily hold in other engines.
> In WebKit, requestAnimationFrame and layout are separate tasks, so it's
> possible for the first step_timeout to fire in between rAF and layout,
> leading to test flakiness. This CL makes tests wait for an additional
> step_timeout to account for this.
>
> Change-Id: Iad80943db184bc4519ab323c3bd7cfac1256e175
> Reviewed-on: https://chromium-review.googlesource.com/1214176
> WPT-Export-Revision: 5756f6a53bc7f6ad87104c3f3ae855d8647070f3
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → Layout
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=31da5dab609e50090286c774657dff2d3c0ea836
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Ran 25 tests and 103 subtests
OK : 25
PASS : 102
FAIL : 1
Assignee | ||
Comment 5•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4fc3021198f648aabed0a3a4f7cd5a865f7a283
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/075ae9254379
[wpt PR 12901] - Loosen timing expectation in IntersectionObserver WPTs, a=testonly
Comment 7•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 8•6 years ago
|
||
Backed out for WPT mass failure at /fullscreen/idlharness.window.html
Backout: https://hg.mozilla.org/mozilla-central/rev/e1a681345945ab8c8b8270afcd2f62bf042226c2
Failure push:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception&classifiedState=unclassified&revision=be6801cdeb537afa655bbd67d12ead8dc01c6c38
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3f3f67d1c0bf5359ac39ddddec5999ceb928e7ca
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199470643&repo=mozilla-central&lineNumber=1487
Status: RESOLVED → REOPENED
status-firefox64:
fixed → ---
Flags: needinfo?(james)
Resolution: FIXED → ---
Target Milestone: mozilla64 → ---
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56c514060216
[wpt PR 12901] - Loosen timing expectation in IntersectionObserver WPTs, a=testonly
Comment 10•6 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Updated•6 years ago
|
Flags: needinfo?(james)
You need to log in
before you can comment on or make changes to this bug.
Description
•