Closed
Bug 1489676
Opened 6 years ago
Closed 6 years ago
Teach the ComputeSquaredDistance derive about #[animation(constant)]
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
ArcFlag is just landed: https://hg.mozilla.org/mozilla-central/rev/7395025cecec#l4.375
Comment 3•6 years ago
|
||
Comment on attachment 9007392 [details] Bug 1489676 - Teach ComputeSquaredDistance derive about #[animation(constant)]. Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9007392 -
Flags: review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/85d1a0c3f60c Teach ComputeSquaredDistance derive about #[animation(constant)]. r=xidorn
Comment 5•6 years ago
|
||
Backed out changeset 85d1a0c3f60c (Bug 1489676) for mochitest failures at dom/animation/test/mozilla/test_distance_of_path_function.html on a CLOSED TREE https://treeherder.mozilla.org/logviewer.html#?job_id=198380116&repo=autoland&lineNumber=7937 [task 2018-09-10T10:22:06.134Z] 10:22:06 INFO - TEST-START | dom/animation/test/mozilla/test_distance_of_filter.html [task 2018-09-10T10:22:06.251Z] 10:22:06 INFO - GECKO(1818) | ++DOMWINDOW == 77 (0xde5edc00) [pid = 1818] [serial = 77] [outer = 0xe102ea60] [task 2018-09-10T10:22:06.461Z] 10:22:06 INFO - GECKO(1818) | MEMORY STAT | vsize 571MB | residentFast 283MB | heapAllocated 94MB [task 2018-09-10T10:22:06.482Z] 10:22:06 INFO - TEST-OK | dom/animation/test/mozilla/test_distance_of_filter.html | took 349ms [task 2018-09-10T10:22:06.531Z] 10:22:06 INFO - GECKO(1818) | ++DOMWINDOW == 78 (0xde484000) [pid = 1818] [serial = 78] [outer = 0xe102ea60] [task 2018-09-10T10:22:06.609Z] 10:22:06 INFO - TEST-START | dom/animation/test/mozilla/test_distance_of_path_function.html [task 2018-09-10T10:22:06.728Z] 10:22:06 INFO - GECKO(1818) | ++DOMWINDOW == 79 (0xde4a9800) [pid = 1818] [serial = 79] [outer = 0xe102ea60] [task 2018-09-10T10:22:06.826Z] 10:22:06 INFO - TEST-INFO | started process screentopng [task 2018-09-10T10:22:07.398Z] 10:22:07 INFO - TEST-INFO | screentopng: exit 0 [task 2018-09-10T10:22:07.398Z] 10:22:07 INFO - Buffered messages logged at 10:22:06 [task 2018-09-10T10:22:07.399Z] 10:22:07 INFO - TEST-PASS | dom/animation/test/mozilla/test_distance_of_path_function.html | - : Elided 11 passes or known failures. [task 2018-09-10T10:22:07.399Z] 10:22:07 INFO - Buffered messages finished [task 2018-09-10T10:22:07.400Z] 10:22:07 INFO - TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_distance_of_path_function.html | The elliptical arc curve commands - The elliptical arc curve commands: assert_equals: path("M 0 0 A 5 5 10 0 1 30 30") and path("M 0 0 A 4 4 5 0 0 20 20") expected 15.0996688705415 but got 0 [task 2018-09-10T10:22:07.401Z] 10:22:07 INFO - TEST-PASS | dom/animation/test/mozilla/test_distance_of_path_function.html | - : Elided 2 passes or known failures. [task 2018-09-10T10:22:07.402Z] 10:22:07 INFO - GECKO(1818) | MEMORY STAT | vsize 571MB | residentFast 284MB | heapAllocated 95MB [task 2018-09-10T10:22:07.402Z] 10:22:07 INFO - TEST-OK | dom/animation/test/mozilla/test_distance_of_path_function.html | took 329ms [task 2018-09-10T10:22:07.405Z] 10:22:07 INFO - GECKO(1818) | ++DOMWINDOW == 80 (0xde489c00) [pid = 1818] [serial = 80] [outer = 0xe102ea60]
Backout by dvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e6f46dda737 Backed out changeset 85d1a0c3f60c for mochitest failures at dom/animation/test/mozilla/test_distance_of_path_function.html on a CLOSED TREE
Assignee | ||
Comment 7•6 years ago
|
||
That test is testing a path that is not animatable. Boris, should I update the test to expect 0, or make the two flags the same? Thanks!
Flags: needinfo?(boris.chiou)
Updated•6 years ago
|
Flags: needinfo?(emilio)
Comment 8•6 years ago
|
||
Thanks for updating this. Let’s make the two flags the same.
Flags: needinfo?(boris.chiou)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(emilio)
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/bf7c2b75f996 Teach ComputeSquaredDistance derive about #[animation(constant)]. r=xidorn
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bf7c2b75f996
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•