1489693 - Bookmark is created at the wrong position

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[u623888]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Steps to reproduce:

create a new bookmark or move an existing bookmark to a different folder.


Actual results:

sometimes the bookmark does not appear at the end of existing bookmarks but in a random position in the list.


Expected results:

the bookmark should be at the last position in the specified folder.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

[Tracking Requested - why for this release]:
I guess this is an issue with 62, right?

Comment 2

[u623888]

(In reply to Sylvestre Ledru [:sylvestre] from comment #1)
> [Tracking Requested - why for this release]:
> I guess this is an issue with 62, right?

Yes it is. But I've noticed this bug at least since 61.

Comment 3

[Mark Banner (:standard8)]

Please can you try this:

* Go to Help -> Troubleshooting Information
* Scroll down the page to find the "Places Database" section (it is near the bottom).
* Click the "Verify Integrity" button, this may take a few seconds to run.

Once that has run, restart Firefox, and then see if the issue re-occurs. If it does, it would be very useful to have more precise details for steps to repeat (e.g. possible bookmark related actions before it happened).

We've heard a couple of rumours of things like this, but we haven't been able to reproduce or work out what might cause it.

Also, if you have any bookmark related extensions that would be useful to know as well.

Comment 4

[u623888]

(In reply to Mark Banner (:standard8) from comment #3)
> Please can you try this:
> 
> * Go to Help -> Troubleshooting Information
> * Scroll down the page to find the "Places Database" section (it is near the
> bottom).
> * Click the "Verify Integrity" button, this may take a few seconds to run.
> 
> Once that has run, restart Firefox, and then see if the issue re-occurs. If
> it does, it would be very useful to have more precise details for steps to
> repeat (e.g. possible bookmark related actions before it happened).
> 
> We've heard a couple of rumours of things like this, but we haven't been
> able to reproduce or work out what might cause it.
> 
> Also, if you have any bookmark related extensions that would be useful to
> know as well.

I have followed the steps and I'm unable to reproduce the bug so far.
It happened in the past without any bookmark extensions installed.
I believe the problem appeared in firefox 60 or 61. It might be easier to audit the changes in the code, since the bug is not easy to reproduce.

Comment 5

[Mark Banner (:standard8)]

(In reply to clavius from comment #4)
> I have followed the steps and I'm unable to reproduce the bug so far.
> It happened in the past without any bookmark extensions installed.
> I believe the problem appeared in firefox 60 or 61. It might be easier to
> audit the changes in the code, since the bug is not easy to reproduce.

If that has fixed it, then it is possible the positions of the bookmarks in the database were out of sync for some reason.

Of course, you might not have hit the actual issue just yet...

Whilst an audit would be nice, there were actually a lot of changes in recent versions which could have affected positions. All those changes were covered by automated tests, and the basics obviously are working OK. Therefore we could be looking at an edge case, but that's really hard to know. As a result those factors plus time involved makes an audit impractical.

I think for now I'll close this as works for me. If you are able to reproduce later, please feel free to re-open and try and give as much detail as possible as to which folders, the positions of bookmarks before & after, and anything else that might be related.