Add section to show_bug displaying the status of associated revisions

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 months ago
a month ago

People

(Reporter: mcote, Assigned: dkl)

Tracking

Development

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

3 months ago
Similar to what we did with MozReview, let's add a section to show_bug that shows the status of any revisions associated with the bug, without any translation.  Ideally we would display the same icons with the same tooltips.  The information should be limited to the summary, revision status (e.g. "Needs Review", "Accepted", "Closed", etc.), and the names and statuses of current reviewers ("Review Requested", "Blocking Review", "Accepted", "Requested Changes", etc.).
(Reporter)

Comment 1

3 months ago
It was discussed at a meeting that screenscraping may (unfortunately) be the best option here due to the complexity of determining statuses via the Conduit API and due to potential changes to the underlying models.
(Reporter)

Comment 2

3 months ago
Eventually it would be nice to hide revision attachments from the attachments table in lieu of this new table, but we'll have to leave it for now until we determine alternatives to other types of flags (e.g. uplifts).
(Assignee)

Comment 3

3 months ago
Created attachment 9007772 [details] [review]
GitHub Pull Request
Assignee: nobody → dkl
Status: NEW → ASSIGNED
(Assignee)

Comment 4

2 months ago
Created attachment 9021957 [details] [review]
GitHub Pull Request
Attachment #9007772 - Attachment is obsolete: true

Updated

2 months ago
Depends on: 1487422
Created attachment 9022233 [details]
Sliced Font Awesome 2.7 font w/ 7 required icons
Created attachment 9023628 [details]
Sliced Font Awesome 2.7 w/ even more icons

Added:

* fa-code (\f121)
* fa-times-circle-o (\f05c)
* fa-flag (\f024)
* and a few more that can be found at https://github.com/phacility/phabricator/tree/master/src/applications/differential/xaction
Attachment #9022298 - Attachment is obsolete: true
(Assignee)

Comment 8

a month ago
Merged to master.
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.