1489706 - Add section to show_bug displaying the status of associated revisions

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, enhancement)

Description

[Mark Côté [:mcote]]

Similar to what we did with MozReview, let's add a section to show_bug that shows the status of any revisions associated with the bug, without any translation.  Ideally we would display the same icons with the same tooltips.  The information should be limited to the summary, revision status (e.g. "Needs Review", "Accepted", "Closed", etc.), and the names and statuses of current reviewers ("Review Requested", "Blocking Review", "Accepted", "Requested Changes", etc.).

Comment 1

[Mark Côté [:mcote]]

It was discussed at a meeting that screenscraping may (unfortunately) be the best option here due to the complexity of determining statuses via the Conduit API and due to potential changes to the underlying models.

Comment 2

[Mark Côté [:mcote]]

Eventually it would be nice to hide revision attachments from the attachments table in lieu of this new table, but we'll have to leave it for now until we determine alternatives to other types of flags (e.g. uplifts).

Comment 3

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 4

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 5

[Kohei Yoshino [:kohei]]

Attachment: Sliced Font Awesome 2.7 font w/ 7 required icons

Comment 6

[Kohei Yoshino [:kohei]]

Attachment: Sliced Font Awesome 2.7 font w/ more required icons

Added other icons to the slice.

https://github.com/phacility/phabricator/blob/master/src/view/phui/PHUIStatusItemView.php#L12-L25

Comment 7

[Kohei Yoshino [:kohei]]

Attachment: Sliced Font Awesome 2.7 w/ even more icons

Added:

* fa-code (\f121)
* fa-times-circle-o (\f05c)
* fa-flag (\f024)
* and a few more that can be found at https://github.com/phacility/phabricator/tree/master/src/applications/differential/xaction

Comment 8

[David Lawrence [:dkl]]

Merged to master.