Closed Bug 1489706 Opened 2 years ago Closed 2 years ago

Add section to show_bug displaying the status of associated revisions

Categories

(bugzilla.mozilla.org :: Phabricator Integration, enhancement)

Development
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mcote, Assigned: dkl)

References

Details

Attachments

(2 files, 3 obsolete files)

Similar to what we did with MozReview, let's add a section to show_bug that shows the status of any revisions associated with the bug, without any translation.  Ideally we would display the same icons with the same tooltips.  The information should be limited to the summary, revision status (e.g. "Needs Review", "Accepted", "Closed", etc.), and the names and statuses of current reviewers ("Review Requested", "Blocking Review", "Accepted", "Requested Changes", etc.).
It was discussed at a meeting that screenscraping may (unfortunately) be the best option here due to the complexity of determining statuses via the Conduit API and due to potential changes to the underlying models.
Eventually it would be nice to hide revision attachments from the attachments table in lieu of this new table, but we'll have to leave it for now until we determine alternatives to other types of flags (e.g. uplifts).
Attached file GitHub Pull Request (obsolete) —
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attached file GitHub Pull Request
Attachment #9007772 - Attachment is obsolete: true
Depends on: 1487422
Attachment #9022233 - Attachment is obsolete: true
Added:

* fa-code (\f121)
* fa-times-circle-o (\f05c)
* fa-flag (\f024)
* and a few more that can be found at https://github.com/phacility/phabricator/tree/master/src/applications/differential/xaction
Attachment #9022298 - Attachment is obsolete: true
Merged to master.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Flags: needinfo?(m7md.alfdyly33)
Flags: needinfo?(m7md.alfdyly33)
You need to log in before you can comment on or make changes to this bug.