[de-xbl] Remove folderSummary-location.

RESOLVED FIXED in Thunderbird 64.0

Status

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: arshad, Assigned: arshad)

Tracking

(Blocks 1 bug)

Trunk
Thunderbird 64.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

Assignee: nobody → arshdkhn1
Status: NEW → ASSIGNED
Posted patch foldersummarylocation.patch (obsolete) — Splinter Review
Attachment #9007423 - Flags: review?(mkmelin+mozilla)
Blocks: 1489747
No longer blocks: 1489747
Comment on attachment 9007423 [details] [diff] [review]
foldersummarylocation.patch

Review of attachment 9007423 [details] [diff] [review]:
-----------------------------------------------------------------

Seems ok, r=mkmelin
Attachment #9007423 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 9007423 [details] [diff] [review]
foldersummarylocation.patch

Review of attachment 9007423 [details] [diff] [review]:
-----------------------------------------------------------------

i didnt add anonid to element, i guess this will break some test..
Posted patch foldersummarylocation.patch (obsolete) — Splinter Review
Attachment #9007423 - Attachment is obsolete: true
added anonid, so that test that might have crashed, passes.
Posted patch foldersummarylocation.patch (obsolete) — Splinter Review
Attachment #9009065 - Attachment is obsolete: true
Posted patch foldersummarylocation.patch (obsolete) — Splinter Review
Attachment #9012523 - Attachment is obsolete: true
Attachment #9014307 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9014307 [details] [diff] [review]
foldersummarylocation.patch

Review of attachment 9014307 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but it doesn't apply cleanly, so please provide an update. r=mkmelin
Attachment #9014307 - Flags: review?(mkmelin+mozilla) → review+
Magnus, I donno why it is not applying cleanly. I have rebased once again.. Can you check again?
Attachment #9014307 - Attachment is obsolete: true
Flags: needinfo?(mkmelin+mozilla)
Ah must be my checkout that's not on tip
Flags: needinfo?(mkmelin+mozilla)
Keywords: checkin-needed
Attachment #9014385 - Flags: review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/042d0c2e5153
Removing folderSummary-location; r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
You need to log in before you can comment on or make changes to this bug.