Closed
Bug 1489737
Opened 7 years ago
Closed 7 years ago
[de-xbl] Remove folderSummary-location.
Categories
(Thunderbird :: Mail Window Front End, task)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 64.0
People
(Reporter: arshad, Assigned: arshad)
References
Details
Attachments
(1 file, 4 obsolete files)
3.01 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → arshdkhn1
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Blocks: tb-war-on-xbl
Assignee | ||
Updated•7 years ago
|
Attachment #9007423 -
Flags: review?(mkmelin+mozilla)
Comment 2•7 years ago
|
||
Comment on attachment 9007423 [details] [diff] [review]
foldersummarylocation.patch
Review of attachment 9007423 [details] [diff] [review]:
-----------------------------------------------------------------
Seems ok, r=mkmelin
Attachment #9007423 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 9007423 [details] [diff] [review]
foldersummarylocation.patch
Review of attachment 9007423 [details] [diff] [review]:
-----------------------------------------------------------------
i didnt add anonid to element, i guess this will break some test..
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #9007423 -
Attachment is obsolete: true
Assignee | ||
Comment 5•7 years ago
|
||
added anonid, so that test that might have crashed, passes.
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #9009065 -
Attachment is obsolete: true
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #9012523 -
Attachment is obsolete: true
Attachment #9014307 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
Comment on attachment 9014307 [details] [diff] [review]
foldersummarylocation.patch
Review of attachment 9014307 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, but it doesn't apply cleanly, so please provide an update. r=mkmelin
Attachment #9014307 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 10•7 years ago
|
||
Magnus, I donno why it is not applying cleanly. I have rebased once again.. Can you check again?
Attachment #9014307 -
Attachment is obsolete: true
Flags: needinfo?(mkmelin+mozilla)
Comment 11•7 years ago
|
||
Ah must be my checkout that's not on tip
Flags: needinfo?(mkmelin+mozilla)
Keywords: checkin-needed
Updated•7 years ago
|
Attachment #9014385 -
Flags: review+
Comment 12•7 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/042d0c2e5153
Removing folderSummary-location; r=mkmelin
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 64.0
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•