Closed Bug 1489737 Opened 2 years ago Closed 2 years ago

[de-xbl] Remove folderSummary-location.

Categories

(Thunderbird :: Mail Window Front End, task)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 64.0

People

(Reporter: arshad, Assigned: arshad)

References

Details

Attachments

(1 file, 4 obsolete files)

foldersummarylocation.patch
3.01 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
Assignee: nobody → arshdkhn1
Status: NEW → ASSIGNED
Attached patch foldersummarylocation.patch (obsolete) — — Splinter Review
Blocks: tb-war-on-xbl
Attachment #9007423 - Flags: review?(mkmelin+mozilla)
Blocks: 1489747
No longer blocks: 1489747
Comment on attachment 9007423 [details] [diff] [review]
foldersummarylocation.patch

Review of attachment 9007423 [details] [diff] [review]:
-----------------------------------------------------------------

Seems ok, r=mkmelin
Attachment #9007423 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 9007423 [details] [diff] [review]
foldersummarylocation.patch

Review of attachment 9007423 [details] [diff] [review]:
-----------------------------------------------------------------

i didnt add anonid to element, i guess this will break some test..
Attached patch foldersummarylocation.patch (obsolete) — — Splinter Review
Attachment #9007423 - Attachment is obsolete: true
added anonid, so that test that might have crashed, passes.
Attached patch foldersummarylocation.patch (obsolete) — — Splinter Review
Attachment #9009065 - Attachment is obsolete: true
Attached patch foldersummarylocation.patch (obsolete) — — Splinter Review
Attachment #9012523 - Attachment is obsolete: true
Attachment #9014307 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9014307 [details] [diff] [review]
foldersummarylocation.patch

Review of attachment 9014307 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but it doesn't apply cleanly, so please provide an update. r=mkmelin
Attachment #9014307 - Flags: review?(mkmelin+mozilla) → review+
Magnus, I donno why it is not applying cleanly. I have rebased once again.. Can you check again?
Attachment #9014307 - Attachment is obsolete: true
Flags: needinfo?(mkmelin+mozilla)
Ah must be my checkout that's not on tip
Flags: needinfo?(mkmelin+mozilla)
Keywords: checkin-needed
Attachment #9014385 - Flags: review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/042d0c2e5153
Removing folderSummary-location; r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.