1489754 - Send tab devices not appearing on link right-click

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Edouard Oger [:eoger]]

Attachment: Screen Shot 2018-09-08 at 6.31.33 PM.png

This is probably a regression from bug 1470555, I don't have time to investigate further since I'm on pto.

Str:

- Be connected to sync with multiple accounts
- Right click a link, hover the "Send Link to device" menu item.

Expected:
Devices list is shown.

Actual:
Popup is not opening. (see screenshot)

Note that the popup works on non-links (page etc).

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1489754 - Update the caller of populateSendTabToDevicesMenu to use new tab argument. r?adw

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 9007890 [details]
Bug 1489754 - Update the caller of populateSendTabToDevicesMenu to use new tab argument. r?adw

Drew Willcoxon :adw has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e1d6337866d
Update the caller of populateSendTabToDevicesMenu to use new tab argument. r=adw

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/0e1d6337866d

Comment 5

[Camelia Badau [:cbadau], Desktop QA]

I've reproduced the issue on Windows 7 x64 using Nightly 64.0a1 (2018-09-09). 

Verified fixed on Windows 7 x64, Ubuntu 16.04 x64 and macOS 10.13 using Firefox 64 Beta 3 (buildID: 20181022150107).