Closed Bug 1489760 Opened Last year Closed Last year

TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:comm/calendar/test/unit/test_bug350845.js

Categories

(Calendar :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jorgk, Assigned: darktrojan)

Details

Attachments

(1 file)

https://taskcluster-artifacts.net/M2CWT2JZS4S_G5tn3-uyzQ/0/public/logs/live_backing.log says:

05:00:21     INFO -  NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED: JavaScript component does not have a method named: "next"'JavaScript component does not have a method named: "next"' when calling method: [nsIJSEnumerator::next]
05:00:21     INFO -  run_test@/Users/cltbld/tasks/task_1536405408/build/tests/xpcshell/tests/comm/calendar/test/unit/test_bug350845.js:35:8

M-C last good: 3026c40acec365f6606c39234bba5f4e99
M-C first bad: da268c77ac7630925921792ffc32111ae3
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3026c40acec365f6606c39234bba5f4e99&tochange=da268c77ac7630925921792ffc32111ae3

Could be this:
a5dd7c81da0e Kris Maglione - Bug 1489532: Check for nsISimpleEnumerator wrapper before searching existing tear-offs. r=mccr8
Flags: needinfo?(geoff)
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
Attachment #9007523 - Flags: review?(philipp)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/86dfca32fb56
Explicitly mark calItemBase.getParameterEnumerator as an nsISimpleEnumerator. rs=bustage-fix,jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
This looked plausible and worked, so I landed it. PLR please.
Target Milestone: --- → 6.5
Target Milestone: 6.5 → 6.6
Comment on attachment 9007523 [details] [diff] [review]
1489760-parameter-enumerator-1.diff

Review of attachment 9007523 [details] [diff] [review]:
-----------------------------------------------------------------

I would prefer the QI to be at the top of the object definition, r+ with that
Attachment #9007523 - Flags: review?(philipp) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d8244e31ff87
Follow-up: Move calItemBase.getParameterEnumerator's QI up. r=philipp DONTBUILD
You need to log in before you can comment on or make changes to this bug.