Closed Bug 1489784 Opened 6 years ago Closed 6 years ago

Replace mPrefs and mIOService fields with standard Services calls in tabbrowser.xml

Categories

(SeaMonkey :: Tabbed Browser, enhancement, P1)

Product:
SeaMonkey
Component:
Tabbed Browser
Type:
enhancement

Tracking

(seamonkey2.60 wontfix, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
Future
Tracking Flags:
Tracking Status
seamonkey2.60 --- wontfix
seamonkey2.57esr --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file)

1489784-servicestabbrowser.patch
23.38 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review 
The fields mPrefs and mIOService in tabbrowser.xml can be replaced with standard global Services calls.
Not much complexity. The urlbar could take a similar treatment later. Lets see if it breaks something first.
Attachment #9007458 - Flags: review?(iann_bugzilla)
Attachment #9007458 - Flags: approval-comm-esr60?
It did not break anything with me.
Comment on attachment 9007458 [details] [diff] [review]
1489784-servicestabbrowser.patch

r/a=me
Attachment #9007458 - Flags: review?(iann_bugzilla)
Attachment #9007458 - Flags: review+
Attachment #9007458 - Flags: approval-comm-esr60?
Attachment #9007458 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/f3074ef87698
Replace mPrefs and mIOService fields with standard Services calls in tabbrowser.xml. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: