Closed Bug 1489787 Opened Last year Closed Last year

Remove the XPCOM component registration for nsComposeTxtSrvFilter

Categories

(Core :: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

These contract IDs are used from one location in comm-central.

https://dxr.mozilla.org/comm-central/rev/e5e1510b8d914bfa8439b21ba3f73e4f2e83e957/editor/ui/dialogs/content/EdSpellCheck.js#41

I'm planning to remove nsITextServicesFilter here and change the nsIEditorSpellCheck.setFilter() API in order to allow the consumers to achieve the same result by passing a constant instead of an object at the API boundary.  Should be a very simple patch to update the c-c call site.  My upcoming patches here can be used as an example.
Depends on: 1489788
Thanks Ehsan, I filed bug 1489788 for the C-C editor/ work.
Comment on attachment 9007464 [details]
Bug 1489787 - Part 1: Remove nsITextServicesFilter and replace nsIEditorSpellCheck.setFilter() with nsIEditorSpellCheck.setFilterType(); r=masayuki

Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) has approved the revision.
Attachment #9007464 - Flags: review+
Comment on attachment 9007465 [details]
Bug 1489787 - Part 2: Remove the XPCOM component registration for nsComposeTxtSrvFilter; r=masayuki

Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) has approved the revision.
Attachment #9007465 - Flags: review+
Comment on attachment 9007466 [details]
Bug 1489787 - Part 3: Decomtaminate nsComposeTxtSrvFilter; r=masayuki

Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) has approved the revision.
Attachment #9007466 - Flags: review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06df991ebef4
Part 1: Remove nsITextServicesFilter and replace nsIEditorSpellCheck.setFilter() with nsIEditorSpellCheck.setFilterType(); r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/a086d561b85e
Part 2: Remove the XPCOM component registration for nsComposeTxtSrvFilter; r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/005a2bc8aec5
Part 3: Decomtaminate nsComposeTxtSrvFilter; r=masayuki
You need to log in before you can comment on or make changes to this bug.