Closed Bug 1489790 Opened Last year Closed Last year

Remove the XPCOM component registration for several commandhandler classes

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(12 files)

46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
46 bytes, text/x-phabricator-request
baku
: review+
Details | Review
I have a stack of patches to clean up many of the unneeded XPCOM component registrations for these classes...
Comment on attachment 9007467 [details]
Bug 1489790 - Part 1: Remove the XPCOM component registration for nsControllerCommandTable as well as kHTMLEditorCommandTableCID and kHTMLEditorDocStateCommandTableCID; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007467 - Flags: review+
Comment on attachment 9007468 [details]
Bug 1489790 - Part 2: Remove the XPCOM component registration for NS_WINDOWCOMMANDTABLE_CID; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007468 - Flags: review+
Comment on attachment 9007469 [details]
Bug 1489790 - Part 3: Remove the XPCOM component registration for NS_EDITORCOMMANDTABLE_CID; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007469 - Flags: review+
Comment on attachment 9007470 [details]
Bug 1489790 - Part 4: Remove the XPCOM component registration for NS_EDITINGCOMMANDTABLE_CID; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007470 - Flags: review+
Comment on attachment 9007471 [details]
Bug 1489790 - Part 5: Remove the XPCOM component registration for @mozilla.org/dom/window-controller;1; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007471 - Flags: review+
Comment on attachment 9007472 [details]
Bug 1489790 - Part 6: Add an overload of nsEditingSession::SetupEditorCommandController which takes a creator function argument instead of a contract ID; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007472 - Flags: review+
Comment on attachment 9007473 [details]
Bug 1489790 - Part 7: Remove the XPCOM component registration for @mozilla.org/editor/editingcontroller;1; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007473 - Flags: review+
Comment on attachment 9007474 [details]
Bug 1489790 - Part 8: Remove the XPCOM component registration for @mozilla.org/editor/editorcontroller;1; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007474 - Flags: review+
Comment on attachment 9007475 [details]
Bug 1489790 - Part 9: Remove the XPCOM component registration for @mozilla.org/editor/htmleditorcontroller;1; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007475 - Flags: review+
Comment on attachment 9007476 [details]
Bug 1489790 - Part 10: Remove the XPCOM component registration for @mozilla.org/editor/editordocstatecontroller;1; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007476 - Flags: review+
Comment on attachment 9007477 [details]
Bug 1489790 - Part 11: Remove the overload of nsEditingSession::SetupEditorCommandController which takes a string and uses the XPCOM service manager to create the controller; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007477 - Flags: review+
Comment on attachment 9007478 [details]
Bug 1489790 - Part 12: Refactor the common code out of the controller/commandtable constructor functions; r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9007478 - Flags: review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5353a7ddf87c
Part 1: Remove the XPCOM component registration for nsControllerCommandTable as well as kHTMLEditorCommandTableCID and kHTMLEditorDocStateCommandTableCID; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ebefb4dfaba
Part 2: Remove the XPCOM component registration for NS_WINDOWCOMMANDTABLE_CID; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecb3f1f42294
Part 3: Remove the XPCOM component registration for NS_EDITORCOMMANDTABLE_CID; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/a602ee5bc056
Part 4: Remove the XPCOM component registration for NS_EDITINGCOMMANDTABLE_CID; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/effc266bc7e1
Part 5: Remove the XPCOM component registration for @mozilla.org/dom/window-controller;1; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/c578fb3304f1
Part 6: Add an overload of nsEditingSession::SetupEditorCommandController which takes a creator function argument instead of a contract ID; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b0247a1496a
Part 7: Remove the XPCOM component registration for @mozilla.org/editor/editingcontroller;1; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b97390b3b8c
Part 8: Remove the XPCOM component registration for @mozilla.org/editor/editorcontroller;1; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/a84e71d43f2f
Part 9: Remove the XPCOM component registration for @mozilla.org/editor/htmleditorcontroller;1; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bf6928fd462
Part 10: Remove the XPCOM component registration for @mozilla.org/editor/editordocstatecontroller;1; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/5719833485cf
Part 11: Remove the overload of nsEditingSession::SetupEditorCommandController which takes a string and uses the XPCOM service manager to create the controller; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/598c02ce2316
Part 12: Refactor the common code out of the controller/commandtable constructor functions; r=baku
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.