Closed Bug 1489806 Opened Last year Closed Last year
Avoid |using namespace js::...| across different js engine components
46 bytes, text/x-phabricator-request
|Details | Review|
To reduce coupling between parts of the engine, I'd like to avoid top-level |using namespace js::...| for other components than the one the file belongs to. This patch removes most of them. Some remaining cases: - builtin/ReflectParse.cpp uses js::frontend - wasm/AsmJS.cpp uses js::frontend - irregexp/NativeRegExpMacroAssembler.cpp uses js::jit - util/Unicode.cpp uses js::unicode
To reduce coupling between components of engine, avoid top-level |using namespace js::...;| between distinct components. This fixes most but a few very intertwined cases remain. MozReview-Commit-ID: 1ftg5aIADpt
Comment on attachment 9007493 [details] Bug 1489806 - Avoid using namespaces across modules of js/src Jeff Walden [:Waldo] has approved the revision.
Attachment #9007493 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/d7b1d18e629b Avoid using namespaces across modules of js/src r=jwalden
You need to log in before you can comment on or make changes to this bug.