Closed Bug 1489825 Opened Last year Closed 11 months ago

Label for calendar preferences not shown immediately

Categories

(Calendar :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1482351 +++

In bug 1482351 we set up for the calendar preferences before the page shows, but the label for the button in the left-hand column is not shown until the overlay loads.

We need a way to get the string that isn't going to fail if the extension is not enabled.
Keywords: checkin-needed
I see no better way to do this. It's going to need some special case somewhere, even if the string is inside the extension.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9007526 - Flags: review?(acelists)
I think this needs to be in beta, so can we arrange a review soon please? :-)
Comment on attachment 9007526 [details] [diff] [review]
1489825-calendar-pref-label-1.diff

Review of attachment 9007526 [details] [diff] [review]:
-----------------------------------------------------------------

This puts LT string into TB dtd file. I'd like to hear from Fallen if this is the best way.
Attachment #9007526 - Flags: review?(philipp)
Comment on attachment 9007526 [details] [diff] [review]
1489825-calendar-pref-label-1.diff

Review of attachment 9007526 [details] [diff] [review]:
-----------------------------------------------------------------

Though I am not sure I like the direction we are heading in with this, I think this would be ok. Remind me, why can't we insert the pane dynamically from Lightning code?
Attachment #9007526 - Flags: review?(philipp) → review+
We do, but we have a placeholder for it to solve all kinds of issues with loading and choosing the right pane. The most annoying (for a user) being that the tab on the left doesn't show up until much later than the page loading and causes a visual interruption. I fixed that but without this patch it still doesn't have a label until we get around to loading the calendar pane.
(In reply to Philipp Kewisch [:Fallen] [:📆] from comment #5)
> Though I am not sure I like the direction we are heading in with this, I
> think this would be ok. Remind me, why can't we insert the pane dynamically
> from Lightning code?

Bug 1482351 comment 14. It looks visually ugly when the label is displayed much later than the prefs page item itself and LT icon.
Flags: needinfo?(philipp)
Attachment #9007526 - Flags: review?(acelists) → review+
Keywords: checkin-needed
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/aaeeda026e11
Move string for calendar preferences label to mail's preferences.dtd; r=aceman, Fallen
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: needinfo?(philipp)
Target Milestone: --- → 6.6
You need to log in before you can comment on or make changes to this bug.