1489844 - Port DOMPrefs to StaticPrefs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

DOMPrefs was implemented before StaticPrefs and it does similar things: atomic boolean/uint32_t static prefs. It's time to remove it and switch to StaticPrefs.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 1 - canvas_imagebitmap_extensions_enabled

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 2 - dom.caches.enabled

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 3 - dom.caches.testing.enabled

Comment 4

[Andrea Marchesini [:baku]]

Attachment: part 4 - dom.performance.enable_user_timing_logging

Comment 5

[Andrea Marchesini [:baku]]

Attachment: part 5 - dom.webnotifications.enabled

Comment 6

[Andrea Marchesini [:baku]]

Attachment: part 6 - dom.webnotifications.serviceworker.enabled

Comment 7

[Andrea Marchesini [:baku]]

Attachment: part 7 - dom.webnotifications.requireinteraction.enabled

Comment 8

[Andrea Marchesini [:baku]]

Attachment: part 8 - dom.serviceWorkers.enabled

Comment 9

[Andrea Marchesini [:baku]]

Attachment: part 9 - dom.serviceWorkers.testing.enabled

Comment 10

[Andrea Marchesini [:baku]]

Attachment: part 10 - dom.storageManager.enabled

Comment 11

[Andrea Marchesini [:baku]]

Attachment: part 11 - dom.promise_rejection_events.enabled

Comment 12

[Andrea Marchesini [:baku]]

Attachment: part 12 - dom.push.enabled

Comment 13

[Andrea Marchesini [:baku]]

Attachment: part 13 - dom.streams.enabled

Comment 14

[Andrea Marchesini [:baku]]

Attachment: part 14 - gfx.offscreencanvas.enabled

Comment 15

[Andrea Marchesini [:baku]]

Attachment: part 15 - dom.webkitBlink.dirPicker.enabled

Comment 16

[Andrea Marchesini [:baku]]

Attachment: part 16 - dom.netinfo.enabled

Comment 17

[Andrea Marchesini [:baku]]

Attachment: part 17 - dom.fetchObserver.enabled

Comment 18

[Andrea Marchesini [:baku]]

Attachment: part 18 - privacy.resistFingerprinting

Comment 19

[Andrea Marchesini [:baku]]

Attachment: part 19 - privacy.resistFingerprinting.autoDeclineNoUserInputCanvasPrompts

Comment 20

[Andrea Marchesini [:baku]]

Attachment: part 20 - devtools.enabled

Comment 21

[Andrea Marchesini [:baku]]

Attachment: part 21 - dom.enable_performance_observer

Comment 22

[Andrea Marchesini [:baku]]

Attachment: part 22 - dom.indexedDB.storageOption.enabled

Comment 23

[Andrea Marchesini [:baku]]

Attachment: part 23 - dom.script_loader.binast_encoding.enabled

Comment 24

[Andrea Marchesini [:baku]]

Attachment: part 24 - dom_performance_enable_scheduler_timing

Comment 25

[Andrea Marchesini [:baku]]

Attachment: part 25 - Renaming macros

Comment 26

[Andrea Marchesini [:baku]]

Attachment: part 26 - browser_dom_window_dump_enabled

Comment 27

[Andrea Marchesini [:baku]]

Attachment: part 27 - dom.worker.canceling.timeoutMilliseconds

Comment 28

[(no longer active)]

Comment on attachment 9007554 [details] [diff] [review]
part 1 - canvas_imagebitmap_extensions_enabled

Review of attachment 9007554 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/ImageBitmap.webidl
@@ +402,5 @@
>  
>  typedef sequence<ChannelPixelLayout> ImagePixelLayout;
>  
>  partial interface ImageBitmap {
> +    [Throws, Func="mozilla::dom::DOMPrefs::canvas_imagebitmap_extensions_enabled"]

Couldn't we use StaticPrefs here directly?  (Could happen in a follow-up).

::: modules/libpref/init/StaticPrefList.h
@@ +204,5 @@
>  
> +VARCACHE_PREF(
> +  "canvas.imagebitmap_extensions.enabled",
> +   canvas_imagebitmap_extensions_enabled,
> +  RelaxedAtomicBool, false

You need to remove this from all.js too.

Comment 29

[(no longer active)]

Comment on attachment 9007555 [details] [diff] [review]
part 2 - dom.caches.enabled

Review of attachment 9007555 [details] [diff] [review]:
-----------------------------------------------------------------

r- on the rest also I guess since it seems you have forgotten about all.js?

(And if possible please use StaticPrefs directly in the IDL -- might require including the header somewhere like BindingDeclarations.h?

::: modules/libpref/init/StaticPrefList.h
@@ +210,5 @@
>  
> +VARCACHE_PREF(
> +  "dom.caches.enabled",
> +   dom_caches_enabled,
> +  RelaxedAtomicBool, false

Ditto, this should be removed from all.js as well.  It also has the wrong default value here (should be true).

Comment 30

[(no longer active)]

(Not gonna go and change all of these flags...) :-)

Comment 31

[Andrea Marchesini [:baku]]

Attachment: part 1 - canvas_imagebitmap_extensions_enabled

Comment 32

[Andrea Marchesini [:baku]]

Attachment: part 2 - dom.caches.enabled

Comment 33

[Andrea Marchesini [:baku]]

Attachment: part 4 - dom.performance.enable_user_timing_logging

Comment 34

[Andrea Marchesini [:baku]]

Attachment: part 5 - dom.webnotifications.enabled

Comment 35

[Andrea Marchesini [:baku]]

Attachment: part 6 - dom.webnotifications.serviceworker.enabled

Comment 36

[Andrea Marchesini [:baku]]

Attachment: part 7 - dom.webnotifications.requireinteraction.enabled

Comment 37

[Andrea Marchesini [:baku]]

Attachment: part 8 - dom.serviceWorkers.enabled

Comment 38

[Andrea Marchesini [:baku]]

Attachment: part 10 - dom.storageManager.enabled

Comment 39

[Andrea Marchesini [:baku]]

Attachment: part 11 - dom.promise_rejection_events.enabled

Comment 40

[Andrea Marchesini [:baku]]

Attachment: part 12 - dom.push.enabled

Comment 41

[Andrea Marchesini [:baku]]

Attachment: part 13 - dom.streams.enabled

Comment 42

[Andrea Marchesini [:baku]]

Attachment: part 14 - gfx.offscreencanvas.enabled

Comment 43

[Andrea Marchesini [:baku]]

Attachment: part 15 - dom.webkitBlink.dirPicker.enabled

Comment 44

[Andrea Marchesini [:baku]]

Attachment: part 16 - dom.netinfo.enabled

Comment 45

[Andrea Marchesini [:baku]]

Attachment: part 18 - privacy.resistFingerprinting

Comment 46

[Andrea Marchesini [:baku]]

Attachment: part 21 - dom.enable_performance_observer

Comment 47

[Andrea Marchesini [:baku]]

Attachment: part 22 - dom.indexedDB.storageOption.enabled

Comment 48

[Andrea Marchesini [:baku]]

Attachment: part 26 - browser_dom_window_dump_enabled

I don't see why this pref should be sticky.

Comment 49

[(no longer active)]

Comment on attachment 9007613 [details] [diff] [review]
part 26 - browser_dom_window_dump_enabled

Review of attachment 9007613 [details] [diff] [review]:
-----------------------------------------------------------------

Please don't forget fixing the mistake below when landing!

::: modules/libpref/init/StaticPrefList.h
@@ +362,5 @@
>  
> +#ifdef MOZILLA_OFFICIAL
> +# define PREF_VALUE false
> +#else
> +# define PREF_VALUE false

true

Comment 50

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/589772c6b052
Port DOMPrefs to StaticPrefs - part 1 - canvas_imagebitmap_extensions_enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/87f024490b34
Port DOMPrefs to StaticPrefs - part 2 - dom.caches.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/b94e1eb738f1
Port DOMPrefs to StaticPrefs - part 3 - dom.caches.testing.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a46ec274800
Port DOMPrefs to StaticPrefs - part 4 - dom.performance.enable_user_timing_logging, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/377121279020
Port DOMPrefs to StaticPrefs - part 5 - dom.webnotifications.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/b30b3c307822
Port DOMPrefs to StaticPrefs - part 6 - dom.webnotifications.serviceworker.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/937ab9053565
Port DOMPrefs to StaticPrefs - part 7 - dom.webnotifications.requireinteraction.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/0048f0e46b90
Port DOMPrefs to StaticPrefs - part 8 - dom.serviceWorkers.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9ecbbbd6400
Port DOMPrefs to StaticPrefs - part 9 - dom.serviceWorkers.testing.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/63618c3a43c5
Port DOMPrefs to StaticPrefs - part 10 - dom.storageManager.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea499874e44b
Port DOMPrefs to StaticPrefs - part 11 - dom.promise_rejection_events.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/db3870aa56f1
Port DOMPrefs to StaticPrefs - part 12 - dom.push.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/76b43cfad8fb
Port DOMPrefs to StaticPrefs - part 13 - dom.streams.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/c83792e6432e
Port DOMPrefs to StaticPrefs - part 14 - gfx.offscreencanvas.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/00b8d8e43988
Port DOMPrefs to StaticPrefs - part 15 - dom.webkitBlink.dirPicker.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/243b32892e21
Port DOMPrefs to StaticPrefs - part 16 - dom.netinfo.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3353251357e
Port DOMPrefs to StaticPrefs - part 17 - dom.fetchObserver.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd1b12a94fc9
Port DOMPrefs to StaticPrefs - part 18 - privacy.resistFingerprinting, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/c236c5795ee6
Port DOMPrefs to StaticPrefs - part 19 - privacy.resistFingerprinting.autoDeclineNoUserInputCanvasPrompts, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/7795b505153b
Port DOMPrefs to StaticPrefs - part 20 - devtools.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/868224db2728
Port DOMPrefs to StaticPrefs - part 21 - dom.enable_performance_observer, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/0af2e4b5ecfb
Port DOMPrefs to StaticPrefs - part 22 - dom.indexedDB.storageOption.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ae8ba9d4036
Port DOMPrefs to StaticPrefs - part 23 - dom.script_loader.binast_encoding.enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2ad5d5fab77
Port DOMPrefs to StaticPrefs - part 24 - dom_performance_enable_scheduler_timing, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7a1326ad53e
Port DOMPrefs to StaticPrefs - part 25 - Renaming macros, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d219572a965
Port DOMPrefs to StaticPrefs - part 26 - browser_dom_window_dump_enabled, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0bf04a1cbbf
Port DOMPrefs to StaticPrefs - part 27 - dom.worker.canceling.timeoutMilliseconds, r=ehsan

Comment 51

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/589772c6b052
https://hg.mozilla.org/mozilla-central/rev/87f024490b34
https://hg.mozilla.org/mozilla-central/rev/b94e1eb738f1
https://hg.mozilla.org/mozilla-central/rev/3a46ec274800
https://hg.mozilla.org/mozilla-central/rev/377121279020
https://hg.mozilla.org/mozilla-central/rev/b30b3c307822
https://hg.mozilla.org/mozilla-central/rev/937ab9053565
https://hg.mozilla.org/mozilla-central/rev/0048f0e46b90
https://hg.mozilla.org/mozilla-central/rev/a9ecbbbd6400
https://hg.mozilla.org/mozilla-central/rev/63618c3a43c5
https://hg.mozilla.org/mozilla-central/rev/ea499874e44b
https://hg.mozilla.org/mozilla-central/rev/db3870aa56f1
https://hg.mozilla.org/mozilla-central/rev/76b43cfad8fb
https://hg.mozilla.org/mozilla-central/rev/c83792e6432e
https://hg.mozilla.org/mozilla-central/rev/00b8d8e43988
https://hg.mozilla.org/mozilla-central/rev/243b32892e21
https://hg.mozilla.org/mozilla-central/rev/e3353251357e
https://hg.mozilla.org/mozilla-central/rev/fd1b12a94fc9
https://hg.mozilla.org/mozilla-central/rev/c236c5795ee6
https://hg.mozilla.org/mozilla-central/rev/7795b505153b
https://hg.mozilla.org/mozilla-central/rev/868224db2728
https://hg.mozilla.org/mozilla-central/rev/0af2e4b5ecfb
https://hg.mozilla.org/mozilla-central/rev/2ae8ba9d4036
https://hg.mozilla.org/mozilla-central/rev/f2ad5d5fab77
https://hg.mozilla.org/mozilla-central/rev/e7a1326ad53e
https://hg.mozilla.org/mozilla-central/rev/2d219572a965
https://hg.mozilla.org/mozilla-central/rev/b0bf04a1cbbf