Closed Bug 1489872 Opened Last year Closed Last year

[remote-dbg-next] Split Connect page in several components

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(4 files)

Current component for Connect page could be refactored in smaller components and should use actions to add and remove network locations.
Upcoming patches will split the ConnectPage component in
several subcomponents, isolate it in a dedicated folder to prevent
cluttering the root component folder.
Depend on D5383. Section markup was duplicated for USB, WiFi and Network sections.
Steps markup was duplicated for USB and WiFi sections. Extracted both as components, 
using props.children to pass their content. Extracted associated CSS.
Depends on D5384. Straightforward extraction of networks list and form as
dedicated components. Related CSS extracted as well.
Comment on attachment 9007614 [details]
Bug 1489872 - Move ConnectPage component to dedicated folder;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #9007614 - Flags: review+
Comment on attachment 9007616 [details]
Bug 1489872 - Extract network locations list and form to dedicated components;r=daisuke,ladybenko

Belén [:ladybenko] has approved the revision.
Attachment #9007616 - Flags: review+
Comment on attachment 9007617 [details]
Bug 1489872 - Use actions to add/remove network locations;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #9007617 - Flags: review+
Comment on attachment 9007616 [details]
Bug 1489872 - Extract network locations list and form to dedicated components;r=daisuke,ladybenko

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #9007616 - Flags: review+
Comment on attachment 9007615 [details]
Bug 1489872 - Extract Steps and Section as components from ConnectPage;r=daisuke,ladybenko

Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #9007615 - Flags: review+
Comment on attachment 9007615 [details]
Bug 1489872 - Extract Steps and Section as components from ConnectPage;r=daisuke,ladybenko

Belén [:ladybenko] has approved the revision.
Attachment #9007615 - Flags: review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d62c43b355
Move ConnectPage component to dedicated folder;r=daisuke
https://hg.mozilla.org/integration/mozilla-inbound/rev/71e883e80098
Extract Steps and Section as components from ConnectPage;r=daisuke,ladybenko
https://hg.mozilla.org/integration/mozilla-inbound/rev/a166a2766049
Extract network locations list and form to dedicated components;r=daisuke,ladybenko
https://hg.mozilla.org/integration/mozilla-inbound/rev/bed00eac89ba
Use actions to add/remove network locations;r=daisuke
Blocks: 1490954
Priority: P3 → P1
You need to log in before you can comment on or make changes to this bug.