Closed
Bug 1489920
Opened 6 years ago
Closed 5 years ago
GData provider icon url in manifest wrong
Categories
(Calendar :: Provider: GData, enhancement)
Calendar
Provider: GData
Tracking
(Not tracked)
RESOLVED
FIXED
6.9
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file)
804 bytes,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Should be changed from "chrome://gdata-provider/content/gcal.png" to "chrome/gdata-provider/content/gcal.png". I'd do it, but this might be a good time to give the icon a refresh.
Comment 1•6 years ago
|
||
Let me check with the brand team if I am allowed to use the new icon as well.
Comment 2•6 years ago
|
||
I have the documents on this on a disk somewhere else I won't be able to access until end of the month. Will get back to this.
Flags: needinfo?(philipp)
Assignee | ||
Comment 3•5 years ago
|
||
This is now causing an error and the extension refuses to load.
Assignee | ||
Comment 4•5 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ed7032c2d636
Use relative URL to icon in GData provider manifest; rs=bustage-fix DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•5 years ago
|
||
I landed it as a bustage fix, which it would be if the test was enabled. (Bug 1481180)
Assignee | ||
Updated•5 years ago
|
Target Milestone: --- → 6.9
Updated•5 years ago
|
Attachment #9044739 -
Flags: review?(philipp) → review+
Updated•5 years ago
|
Flags: needinfo?(philipp)
You need to log in
before you can comment on or make changes to this bug.
Description
•