Closed Bug 1489920 Opened 6 years ago Closed 5 years ago

GData provider icon url in manifest wrong

Categories

(Calendar :: Provider: GData, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

Should be changed from "chrome://gdata-provider/content/gcal.png" to "chrome/gdata-provider/content/gcal.png". I'd do it, but this might be a good time to give the icon a refresh.
Let me check with the brand team if I am allowed to use the new icon as well.
I have the documents on this on a disk somewhere else I won't be able to access until end of the month. Will get back to this.
Flags: needinfo?(philipp)

This is now causing an error and the extension refuses to load.

Attached patch 1489920-gdata-icon-1.diff β€” β€” Splinter Review
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9044739 - Flags: review?(philipp)

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ed7032c2d636
Use relative URL to icon in GData provider manifest; rs=bustage-fix DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

I landed it as a bustage fix, which it would be if the test was enabled. (Bug 1481180)

Target Milestone: --- → 6.9
Attachment #9044739 - Flags: review?(philipp) → review+
Flags: needinfo?(philipp)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: