[Linux/Gtk] Window scrollbars do not visually distinguish between active and inactive windows

RESOLVED FIXED in Firefox 64

Status

()

defect
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks 1 bug)

60 Branch
mozilla64
Unspecified
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 months ago
Follow up from Bug #1442755, this one is about titlebar buttons.

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180301024724

Steps to reproduce:

1. Open Firefox
2. Go to about:config and set browser.tabs.drawInTitlebar to 'true'
3. Open a different application (for example Nautilus or a Terminal)
4. Switch back and forth between the two applications (alt+tab)


Actual results:

The Firefox titlebar doesn't change visually, regardless of whether the window is active or inactive.


Expected results:

With many desktop environments and themes there is a visual indication, when a window is inactive.
For example, in GNOME with the Arc GTK theme the window control buttons switch to grayscale and the overall titlebar content is muted (see attachment).
(Assignee)

Updated

7 months ago
No longer depends on: 1408360
(Assignee)

Updated

7 months ago
No longer depends on: 1489097
(Assignee)

Updated

7 months ago
Summary: [CSD] Window control buttons do not visually distinguish between active and inactive windows → [CSD] Window button icons do not visually distinguish between active and inactive windows
(Assignee)

Comment 1

7 months ago
We may also fix scrollbars and other elements which can be styled for active/inactive state.
(Assignee)

Updated

7 months ago
Summary: [CSD] Window button icons do not visually distinguish between active and inactive windows → [CSD] Window elements do not visually distinguish between active and inactive windows
(Assignee)

Comment 2

7 months ago
The elements are rendered at child content process but focus is at the toplevel parent chrome window. 

We need to find out if the parent window is focused or not. Jim, do you know how to query that? It's generally this situation:

https://dxr.mozilla.org/mozilla-central/rev/423bdf7a802b0d302244492b423609187de39f56/widget/windows/nsNativeThemeWin.cpp#76

Thanks.
Flags: needinfo?(jmathies)
(Assignee)

Updated

7 months ago
Summary: [CSD] Window elements do not visually distinguish between active and inactive windows → [Linux/Gtk] Window elements do not visually distinguish between active and inactive windows
(Assignee)

Comment 3

7 months ago
I copied MacOS approach here, Thanks.
Flags: needinfo?(jmathies)
Comment on attachment 9008647 [details]
Bug 1489963 - [Linux/Gtk] Draw scrollbars on inactive documents with dropdown state, r=jhorak

Jan Horak [:jhorak] has approved the revision.
Attachment #9008647 - Flags: review+
(Assignee)

Updated

7 months ago
Keywords: checkin-needed
Summary: [Linux/Gtk] Window elements do not visually distinguish between active and inactive windows → [Linux/Gtk] Window scrollbars do not visually distinguish between active and inactive windows

Comment 7

7 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/70c9cb74c844
[Linux/Gtk] Draw scrollbars on inactive documents with dropdown state, r=jhorak
Keywords: checkin-needed

Comment 8

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/70c9cb74c844
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Depends on: 1491374
(Assignee)

Comment 9

7 months ago
Backed out due to regression at KDE:
https://bugzilla.mozilla.org/show_bug.cgi?id=1491374
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 10

7 months ago
It also breaks default Gtk+ Adwaita theme. I get correct behavior with Ubuntu Ambiance theme only.
(Assignee)

Updated

7 months ago
Duplicate of this bug: 1492761
Target Milestone: mozilla64 → ---
(Assignee)

Updated

7 months ago
Attachment #9008647 - Attachment is obsolete: true
Comment on attachment 9011746 [details]
Bug 1489963 - Draw scrollbars with Gtk widget state and use backdrop state for inactive scrollbars, r=jhorak

Jan Horak [:jhorak] has approved the revision.
Attachment #9011746 - Flags: review+
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 15

7 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/367e78be79b1
Draw scrollbars with Gtk widget state and use backdrop state for inactive scrollbars, r=jhorak
Keywords: checkin-needed

Comment 16

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/367e78be79b1
Status: REOPENED → RESOLVED
Last Resolved: 7 months ago7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.