1489963 - [Linux/Gtk] Window scrollbars do not visually distinguish between active and inactive windows

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from Bug #1442755, this one is about titlebar buttons.

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180301024724

Steps to reproduce:

1. Open Firefox
2. Go to about:config and set browser.tabs.drawInTitlebar to 'true'
3. Open a different application (for example Nautilus or a Terminal)
4. Switch back and forth between the two applications (alt+tab)


Actual results:

The Firefox titlebar doesn't change visually, regardless of whether the window is active or inactive.


Expected results:

With many desktop environments and themes there is a visual indication, when a window is inactive.
For example, in GNOME with the Arc GTK theme the window control buttons switch to grayscale and the overall titlebar content is muted (see attachment).

Comment 1

[Martin Stránský [:stransky] (ni? me)]

We may also fix scrollbars and other elements which can be styled for active/inactive state.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

The elements are rendered at child content process but focus is at the toplevel parent chrome window. 

We need to find out if the parent window is focused or not. Jim, do you know how to query that? It's generally this situation:

https://dxr.mozilla.org/mozilla-central/rev/423bdf7a802b0d302244492b423609187de39f56/widget/windows/nsNativeThemeWin.cpp#76

Thanks.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

I copied MacOS approach here, Thanks.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1489963 - [Linux/Gtk] Draw scrollbars on inactive documents with dropdown state, r=jhorak

Comment 5

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=14dacb0b42bea67e8d0363ed7a05a924ac3e1b04

Comment 6

[Jan Horak [:jhorak]]

Comment on attachment 9008647 [details]
Bug 1489963 - [Linux/Gtk] Draw scrollbars on inactive documents with dropdown state, r=jhorak

Jan Horak [:jhorak] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70c9cb74c844
[Linux/Gtk] Draw scrollbars on inactive documents with dropdown state, r=jhorak

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/70c9cb74c844

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Backed out due to regression at KDE:
https://bugzilla.mozilla.org/show_bug.cgi?id=1491374

Comment 10

[Martin Stránský [:stransky] (ni? me)]

It also breaks default Gtk+ Adwaita theme. I get correct behavior with Ubuntu Ambiance theme only.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1489963 - Draw scrollbars with Gtk widget state and use backdrop state for inactive scrollbars, r=jhorak

Comment 13

[Jan Horak [:jhorak]]

Comment on attachment 9011746 [details]
Bug 1489963 - Draw scrollbars with Gtk widget state and use backdrop state for inactive scrollbars, r=jhorak

Jan Horak [:jhorak] has approved the revision.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2653f36781c68ee4707f3d2dd9340d14928404f

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/367e78be79b1
Draw scrollbars with Gtk widget state and use backdrop state for inactive scrollbars, r=jhorak

Comment 16

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/367e78be79b1