Closed Bug 1490092 Opened 6 years ago Closed 6 years ago

Permafailing test-verify GECKO(2328) | TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - TypeError: tab is null, can't access property "localName" of it at createTooltip@chrome://browser/content/tabbrowser.js:4104:5

Categories

(Firefox :: Tabbed Browser, defect, P5)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: glowka.tom)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1490092 - Clean opened tabs after Open request in tab test; r=Honza
46 bytes, text/x-phabricator-request
Honza
: review+
Details | Review 
Filed by: toros [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=198474431&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/a8ffxdEoSRqiZBIXqQBpcQ/runs/0/artifacts/public/logs/live_backing.log

17:46:16     INFO - TEST-START | devtools/client/netmonitor/test/browser_net_open_request_in_tab.js
17:46:18     INFO - GECKO(2328) | MEMORY STAT | vsize 754MB | vsizeMaxContiguous 481MB | residentFast 277MB | heapAllocated 113MB
17:46:18     INFO - TEST-OK | devtools/client/netmonitor/test/browser_net_open_request_in_tab.js | took 2136ms
17:46:18     INFO - checking window state
17:46:18    ERROR - GECKO(2328) | TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - TypeError: tab is null, can't access property "localName" of it at createTooltip@chrome://browser/content/tabbrowser.js:4104:5
17:46:18     INFO - GECKO(2328) | onpopupshowing@chrome://browser/content/browser.xul:1:1
17:46:18     INFO - GECKO(2328) | JavaScript error: chrome://browser/content/tabbrowser.js, line 4104: TypeError: tab is null, can't access property "localName" of it
17:46:19     INFO - Console message: [JavaScript Error: "TypeError: tab is null, can't access property "localName" of it" {file: "chrome://browser/content/tabbrowser.js" line: 4104}]
17:46:19     INFO - createTooltip@chrome://browser/content/tabbrowser.js:4104:5
17:46:19     INFO - onpopupshowing@chrome://browser/content/browser.xul:1:1
17:46:19     INFO - 
17:46:19     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 5160
17:46:19     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 4552
17:46:19     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 4236
17:46:19     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 5832
17:46:20     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 5492
17:46:20     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 2328
17:46:20     INFO - TEST-START | Shutdown
17:46:20     INFO - Browser Chrome Test Summary
17:46:20     INFO - Passed:  4
17:46:20     INFO - Failed:  0
17:46:20     INFO - Todo:    0
17:46:20     INFO - Mode:    e10s
17:46:20     INFO - *** End BrowserChrome Test Results ***
17:46:20     INFO - GECKO(2328) | JavaScript error: resource://activity-stream/lib/TopSitesFeed.jsm, line 86: TypeError: setting getter-only property "_currentSearchHostname"
17:46:20     INFO - GECKO(2328) | [Child 4236, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
17:46:20     INFO - GECKO(2328) | [Parent 2328, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
17:46:20     INFO - GECKO(2328) | [Child 5160, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
17:46:20     INFO - GECKO(2328) | [Child 5160, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
17:46:20     INFO - GECKO(2328) | [Parent 2328, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
17:46:20     INFO - GECKO(2328) | [Child 5832, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
17:46:20     INFO - GECKO(2328) | [Parent 2328, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
17:46:20     INFO - GECKO(2328) | [Child 5492, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
17:46:20     INFO - GECKO(2328) | [Parent 2328, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
17:46:20     INFO - GECKO(2328) | [Child 4552, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
17:46:20     INFO - GECKO(2328) | [Parent 2328, Gecko_IOThread] WARNING: file z:/build/build/src/ipc/chromium/src/base/process_util_win.cc, line 188
17:46:20     INFO - GECKO(2328) | 1536601580761	Marionette	DEBUG	Received observer notification xpcom-will-shutdown
17:46:20     INFO - GECKO(2328) | 1536601580761	Marionette	INFO	Stopped listening on port 2828
17:46:20     INFO - GECKO(2328) | 1536601580761	Marionette	DEBUG	Remote service is inactive
17:46:21     INFO - TEST-INFO | Main app process: exit 0
This appears to be a regression from Bug 1473220, since:

17:46:16     INFO - TEST-START | devtools/client/netmonitor/test/browser_net_open_request_in_tab.js
17:46:18     INFO - GECKO(2328) | MEMORY STAT | vsize 754MB | vsizeMaxContiguous 481MB | residentFast 277MB | heapAllocated 113MB
17:46:18     INFO - TEST-OK | devtools/client/netmonitor/test/browser_net_open_request_in_tab.js | took 2136ms
17:46:18     INFO - checking window state
17:46:18    ERROR - GECKO(2328) | TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - TypeError: tab is null, can't access property "localName" of it at createTooltip@chrome://browser/content/tabbrowser.js:4104:5
17:46:18     INFO - GECKO(2328) | onpopupshowing@chrome://browser/content/browser.xul:1:1
17:46:18     INFO - GECKO(2328) | JavaScript error: chrome://browser/content/tabbrowser.js, line 4104: TypeError: tab is null, can't access property "localName" of it
17:46:19     INFO - Console message: [JavaScript Error: "TypeError: tab is null, can't access property "localName" of it" {file: "chrome://browser/content/tabbrowser.js" line: 4104}]
17:46:19     INFO - createTooltip@chrome://browser/content/tabbrowser.js:4104:5
17:46:19     INFO - onpopupshowing@chrome://browser/content/browser.xul:1:1
17:46:19     INFO - 
17:46:19     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 5160
17:46:19     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 4552
17:46:19     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 4236
17:46:19     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 5832
17:46:20     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 5492
17:46:20     INFO - GECKO(2328) | Completed ShutdownLeaks collections in process 2328
17:46:20     INFO - TEST-START | Shutdown
17:46:20     INFO - Browser Chrome Test Summary
17:46:20     INFO - Passed:  4
17:46:20     INFO - Failed:  0
17:46:20     INFO - Todo:    0
17:46:20     INFO - Mode:    e10s
17:46:20     INFO - *** End BrowserChrome Test Results ***

Jan, can you please take a look?
Flags: needinfo?(odvarko)
@Tom, how this test could be affected by the patch in Bug 1473220?

Honza
Flags: needinfo?(glowka.tom)
I found that the test that Bug 1473220 modified had been flawed: it opened 3 new tabs and closed only 1. Now, after the changes, it opens 4 tabs and closes only 1. I am not sure if it is the issue, but worth fixing anyway, right?

I'll push a patch, please check if it make sense.
Flags: needinfo?(glowka.tom)
Comment on attachment 9008014 [details]
Bug 1490092 - Clean opened tabs after Open request in tab test; r=Honza

Jan Honza Odvarko [:Honza] has approved the revision.
Attachment #9008014 - Flags: review+
Honza, I guess we want to check it in, right? If so, please set the checkin-needed as I have no permission to do that.
(In reply to Tom Glowka from comment #6)
> Honza, I guess we want to check it in, right? If so, please set the
> checkin-needed as I have no permission to do that.

Ah, I missed this comment. Please use need-info next time so, it appears on my Bugzilla dashboard, thanks!

Honza
Assignee: nobody → glowka.tom
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)
Keywords: checkin-needed
Ah, it's been there actually ;-)

Honza
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/baa2b88b3ed1
Clean opened tabs after Open request in tab test; r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/baa2b88b3ed1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: