Closed Bug 1490115 Opened Last year Closed Last year

Handle unaccompanied low surrogate pairs in the prefs parser

Categories

(Core :: Preferences: Backend, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(2 files)

Currently they cause the `String::from_utf16()` call to return an error result,
and then the subsequent `unwrap()` on that result aborts.

I found this with a simple fuzzer that I wrote while investigating bug 1489744.
Attachment #9007895 - Flags: review?(mh+mozilla)
Attachment #9007885 - Flags: review?(mh+mozilla) → review+
Attachment #9007895 - Flags: review?(mh+mozilla) → review+
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0c8d0f1cb58
Handle unaccompanied low surrogate pairs in the prefs parser. r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/9533efb267a0
Add extra tests for comment-only inputs. r=glandium
https://hg.mozilla.org/mozilla-central/rev/f0c8d0f1cb58
https://hg.mozilla.org/mozilla-central/rev/9533efb267a0
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.