Closed Bug 1490186 Opened Last year Closed Last year
Firefox does not use xdg-desktop-portal for file selection dialogs
46 bytes, text/x-phabricator-request
|Details | Review|
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0 Build ID: 20180904093908 Steps to reproduce: Open a file selection dialog in Firefox. Actual results: Firefox opens a file selection box based on GtkFileChooserDialog Expected results: Firefox should open a file selection box based on GtkFileChooserNative. This makes use of xdg-desktop-portal, which will better prepare Firefox for eventual flatpak sandboxing, as well as enable Firefox to use native file chooser dialogs on KDE platforms.
This patch makes Firefox's GTK3 platform support use GtkFileChooserNative when available. GtkFileChooserNative transparently uses the desktop portals interface, which enables Firefox to use native Qt file dialogs on KDE, or sandboxed file dialogs in Flatpak.
The patch was submitted here: https://phabricator.services.mozilla.com/D7033
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8ed536957a4b Add GtkFileChooserNative support to Firefox. r=stransky
Backed out changeset 8ed536957a4b (bug 1490186) for FilePicker.cpp build bustages push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=8ed536957a4bfadb1b651af81ccff887ada217ee failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=b26a70a0fe8f22ee4a5118c7c563ab98a115e692&selectedJob=204688589&searchStr=linux%2Copt%2Cbuild-linux%2Fopt%2C%28b%29 backout: https://hg.mozilla.org/integration/autoland/rev/04186081b9031399b1198284f57672aa2eee8229
Oops, did not try compiling with GTK < 3.20. Any way I can submit it to taskcluster?
(In reply to Nathan Moos from comment #5) > Oops, did not try compiling with GTK < 3.20. Any way I can submit it to > taskcluster? I use "./mach try -b do -p linux,linux64,linux64-pgo,linux64-asan,linux64-valgrind -u all -t none" which makes try run from the latest commits.
I don't think I have permissions to use the Try server. Is there any way to re-open my diff in Phabricator?
(In reply to Nathan Moos from comment #7) > I don't think I have permissions to use the Try server. Is there any way to > re-open my diff in Phabricator? I think you can submit another patch, can't you? Also I can send your patch to try if you don't have such permission - just let me know when it's ready.
I reopened the phabricator request, you should be able to send another revision.
Try looks good.
This needs a review before it can be landed. Nathan Moos: Could you please ask for a review?
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/2fd7d3ae070e Add GtkFileChooserNative support to Firefox. r=stransky
Is it possible to apply this patch to Thunderbird? I'm unfamiliar with how much code is shared between the two codebases.
AFAIK recent thunderbird is based on Firefox 60 ESR - you'd need to request to backport this to ESR line which is something I don't recommend.
I'd rather not backport it, but does Thunderbird use the platform layer from mozilla-central? As in, would the next Thunderbird release be able to use this patch?
(In reply to Nathan Moos from comment #18) > I'd rather not backport it, but does Thunderbird use the platform layer from > mozilla-central? As in, would the next Thunderbird release be able to use > this patch? Yes, Thunderbird 68 and later should contain this patch as it's usually based on equal ESR Firefox version (68 in this case).
You need to log in before you can comment on or make changes to this bug.