Closed
Bug 1490212
Opened 6 years ago
Closed 6 years ago
Remove the *XPCOMStringDetector classes
Categories
(Core :: Internationalization, enhancement, P3)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: hsivonen, Assigned: jorgk-bmo)
Details
Attachments
(2 files, 1 obsolete file)
|
7.26 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
2.43 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
These are dead code in m-c. The c-c users could be implemented in terms of nsICharsetDetector instead.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Reporter | |
Updated•6 years ago
|
Keywords: good-first-bug
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 9008473 [details] [diff] [review] 1490212-remove-XPCOMStringDetector.patch [landed in comment #5] Review of attachment 9008473 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #9008473 -
Flags: review?(hsivonen) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Thanks for your help on the related bug in TB!
Keywords: good-first-bug → checkin-needed
Pushed by dvarga@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/00178fecba48 Remove the *XPCOMStringDetector classes. r=hsivonen
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/00178fecba48
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
|
Assignee | |
Updated•6 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Comment 7•6 years ago
|
||
Comment on attachment 9008890 [details] [diff] [review] 1490212-follow-up.patch Review of attachment 9008890 [details] [diff] [review]: ----------------------------------------------------------------- ::: extensions/universalchardet/src/xpcom/nsUdetXPCOMWrapper.h @@ +13,5 @@ > #include "nsIFactory.h" > #include "nsUniversalDetector.h" > > // {12BB8F1B-2389-11d3-B3BF-00805F8A6670} > #define NS_JA_PSMDETECTOR_CID \ Please remove this #define, too, since it, too is unused and obsolete. ::: intl/chardet/nsCyrillicDetector.h @@ +11,2 @@ > // {2002F781-3960-11d3-B3C3-00805F8A6670} > #define NS_RU_PROBDETECTOR_CID \ And these ones, too.
Attachment #9008890 -
Flags: review?(hsivonen) → review+
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9008473 -
Attachment description: 1490212-remove-XPCOMStringDetector.patch → 1490212-remove-XPCOMStringDetector.patch [landed in comment #5]
|
|
Assignee | |
Comment 8•6 years ago
|
||
Addressed review comments, carrying forward Henri's r+.
Attachment #9008890 -
Attachment is obsolete: true
Attachment #9009024 -
Flags: review+
|
||
Comment 10•6 years ago
|
||
Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b3aeeb0a0a8b Follow-up: Remove NS_{JA,RU,UK}*DETECTOR_CID defines. r=hsivonen
Keywords: checkin-needed
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b3aeeb0a0a8b
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•