1490212 - Remove the *XPCOMStringDetector classes

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P3)

Description

[Henri Sivonen (:hsivonen)]

These are dead code in m-c. The c-c users could be implemented in terms of nsICharsetDetector instead.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1490212-remove-XPCOMStringDetector.patch [landed in comment #5]

Comment 2

[Henri Sivonen (:hsivonen)]

Comment on attachment 9008473 [details] [diff] [review]
1490212-remove-XPCOMStringDetector.patch [landed in comment #5]

Review of attachment 9008473 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks for your help on the related bug in TB!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00178fecba48
Remove the *XPCOMStringDetector classes. r=hsivonen

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/00178fecba48

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1490212-follow-up.patch

Missed some :-(

Comment 7

[Henri Sivonen (:hsivonen)]

Comment on attachment 9008890 [details] [diff] [review]
1490212-follow-up.patch

Review of attachment 9008890 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/universalchardet/src/xpcom/nsUdetXPCOMWrapper.h
@@ +13,5 @@
>  #include "nsIFactory.h"
>  #include "nsUniversalDetector.h"
>  
>  // {12BB8F1B-2389-11d3-B3BF-00805F8A6670}
>  #define NS_JA_PSMDETECTOR_CID \

Please remove this #define, too, since it, too is unused and obsolete.

::: intl/chardet/nsCyrillicDetector.h
@@ +11,2 @@
>  // {2002F781-3960-11d3-B3C3-00805F8A6670}
>  #define NS_RU_PROBDETECTOR_CID \

And these ones, too.

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1490212-follow-up.patch (v2)

Addressed review comments, carrying forward Henri's r+.

Comment 9

[Jorg K (CEST = GMT+2)]

Please land the second patch only.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3aeeb0a0a8b
Follow-up: Remove NS_{JA,RU,UK}*DETECTOR_CID defines. r=hsivonen

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b3aeeb0a0a8b