1490227 - Rename the python_mozparsers directory to mozparsers

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Alessio Placitelli [:Dexter]]

As :jezdez pointed out, there is no need to have the package name reflect the distribution name for the parsers. That means we could rename the directory from "build_scripts/python_mozparsers" to "mozparsers" and adjust the setup.py file accordingly.

This would remove the redundant prefix "python_" from all the imports.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Alessio, do you want to set it up as mentored?

Comment 2

[Alessio Placitelli [:Dexter]]

Hey Jannis,

I have a little doubt about this. In order to keep the distributed package name as "python_mozparsers", but to rename the directory as "mozparsers", how should the setup.py be changed? Is it enough to rename the dir and change the "name" property to "mozparsers"? Would the Pypi page remain the same?

[1] - https://searchfox.org/mozilla-central/rev/6c82481caa506a240a626bb44a2b8cbe0eedb3a0/toolkit/components/telemetry/build_scripts/setup.py#17

Comment 3

[Jannis Leidel [:jezdez]]

Sorry for only seeing this now!

The setup.py contains the name of the package on PyPI, which doesn't require the "python" prefix. E.g. https://pypi.org/project/mozanalysis/ is correct, while https://pypi.org/project/python_moztelemetry/ is wrong.

When you change the name in the setup.py, it'll also mean the package on PyPI will be a different one. E.g. https://pypi.org/project/python-mozparsers/ will have to be deprecated/deleted. Since there is literally only one use cases (AFAIK) for this now, I don't think it'll be a problem to do this change now.

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1490227 - Rename python_mozparsers to mozparsers. r?janerik

Comment 5

[Alessio Placitelli [:Dexter]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c14a57634e3c9231a371fc99eb0ab0c13462de29

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b61cf8794a0
Rename python_mozparsers to mozparsers. r=janerik

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2b61cf8794a0

Comment 8

[Alessio Placitelli [:Dexter]]

The renamed package is available at: https://pypi.org/project/mozparsers/