Closed Bug 1490227 Opened 3 years ago Closed 3 years ago
Rename the python
_mozparsers directory to mozparsers
46 bytes, text/x-phabricator-request
|Details | Review|
As :jezdez pointed out, there is no need to have the package name reflect the distribution name for the parsers. That means we could rename the directory from "build_scripts/python_mozparsers" to "mozparsers" and adjust the setup.py file accordingly. This would remove the redundant prefix "python_" from all the imports.
Alessio, do you want to set it up as mentored?
Hey Jannis, I have a little doubt about this. In order to keep the distributed package name as "python_mozparsers", but to rename the directory as "mozparsers", how should the setup.py be changed? Is it enough to rename the dir and change the "name" property to "mozparsers"? Would the Pypi page remain the same?  - https://searchfox.org/mozilla-central/rev/6c82481caa506a240a626bb44a2b8cbe0eedb3a0/toolkit/components/telemetry/build_scripts/setup.py#17
Sorry for only seeing this now! The setup.py contains the name of the package on PyPI, which doesn't require the "python" prefix. E.g. https://pypi.org/project/mozanalysis/ is correct, while https://pypi.org/project/python_moztelemetry/ is wrong. When you change the name in the setup.py, it'll also mean the package on PyPI will be a different one. E.g. https://pypi.org/project/python-mozparsers/ will have to be deprecated/deleted. Since there is literally only one use cases (AFAIK) for this now, I don't think it'll be a problem to do this change now.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/2b61cf8794a0 Rename python_mozparsers to mozparsers. r=janerik
The renamed package is available at: https://pypi.org/project/mozparsers/
You need to log in before you can comment on or make changes to this bug.