Rename the python_mozparsers directory to mozparsers

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P1
normal
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: Dexter, Assigned: Dexter)

Tracking

(Depends on 1 bug)

Trunk
mozilla64
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

As :jezdez pointed out, there is no need to have the package name reflect the distribution name for the parsers. That means we could rename the directory from "build_scripts/python_mozparsers" to "mozparsers" and adjust the setup.py file accordingly.

This would remove the redundant prefix "python_" from all the imports.
Blocks: 1282098
Alessio, do you want to set it up as mentored?
Flags: needinfo?(alessio.placitelli)
Hey Jannis,

I have a little doubt about this. In order to keep the distributed package name as "python_mozparsers", but to rename the directory as "mozparsers", how should the setup.py be changed? Is it enough to rename the dir and change the "name" property to "mozparsers"? Would the Pypi page remain the same?

[1] - https://searchfox.org/mozilla-central/rev/6c82481caa506a240a626bb44a2b8cbe0eedb3a0/toolkit/components/telemetry/build_scripts/setup.py#17
Flags: needinfo?(jezdez)
Flags: needinfo?(alessio.placitelli)
Sorry for only seeing this now!

The setup.py contains the name of the package on PyPI, which doesn't require the "python" prefix. E.g. https://pypi.org/project/mozanalysis/ is correct, while https://pypi.org/project/python_moztelemetry/ is wrong.

When you change the name in the setup.py, it'll also mean the package on PyPI will be a different one. E.g. https://pypi.org/project/python-mozparsers/ will have to be deprecated/deleted. Since there is literally only one use cases (AFAIK) for this now, I don't think it'll be a problem to do this change now.
Flags: needinfo?(jezdez)
Points: --- → 1
Priority: -- → P1
Assignee: nobody → alessio.placitelli
Pushed by aplacitelli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b61cf8794a0
Rename python_mozparsers to mozparsers. r=janerik
https://hg.mozilla.org/mozilla-central/rev/2b61cf8794a0
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
The renamed package is available at: https://pypi.org/project/mozparsers/
Depends on: 1500428
You need to log in before you can comment on or make changes to this bug.