Closed Bug 1490240 Opened Last year Closed Last year

Fix the remaining warnings in the crash reporting code

Categories

(Toolkit :: Crash Reporting, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The crash reporting code contains a number of warnings which forced us to turn off -Werror in clang-cl builds. Some of them are in third-party code but most are in our own stuff and we should fix them ASAP.
Comment on attachment 9008628 [details]
Bug 1490240 - Fix the remaining compiler warnings in the crash reporter

Ted Mielczarek [:ted] [:ted.mielczarek] has approved the revision.
Attachment #9008628 - Flags: review+
Comment on attachment 9008628 [details]
Bug 1490240 - Fix the remaining compiler warnings in the crash reporter

Mike Hommey [:glandium] has approved the revision.
Attachment #9008628 - Flags: review+
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a566d2d6722
Fix the remaining compiler warnings in the crash reporter r=ted,glandium
Sure. Weird, this didn't come up in previous try runs, maybe a recent change I must have missed...
Flags: needinfo?(gsvelto)
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/628ebca30ce3
Fix the remaining compiler warnings in the crash reporter r=ted,glandium
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d6329af610e
Fix the remaining compiler warnings in the crash reporter r=ted,glandium
https://hg.mozilla.org/mozilla-central/rev/8d6329af610e
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Flags: needinfo?(gsvelto)
You need to log in before you can comment on or make changes to this bug.