1490275 - In WebAssembly.Table constructor, call ToString on descriptor.element

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Rather than the current isString() check.

Per spec: https://heycam.github.io/webidl/#es-to-enumeration

Tested in:

wasm/jsapi/table/constructor.any.js

(which runs in jstests and wpt).

Comment 1

[Lars T Hansen [:lth]]

I will post a fix this for review for the sake of compliance and since it'll be a while before there are other table types, but I am not completely sold that the Wasm JS API spec is correct in defining the element type as an enumeration value.  I can easily envision a future where we have strongly (mono)typed tables, and an enumeration will not be adequate to represent the types of table elements.

I'll file a bug on the spec repo to discuss this further.

Comment 2

[Lars T Hansen [:lth]]

Attachment: bug1490275-convert-enum-value.patch

Review for correctness; it may still not land, see my previous comment.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 9009540 [details] [diff] [review]
bug1490275-convert-enum-value.patch

Review of attachment 9009540 [details] [diff] [review]:
-----------------------------------------------------------------

Patch LGTM, and I think your reasoning above too, so we could wait for spec feedback.

::: testing/web-platform/meta/wasm/jsapi/table/constructor.any.js.ini
@@ -1,2 @@
>  [constructor.any.html]
> -  [Type conversion for descriptor.element]

You can review the file, if there are no meta annotations anymore.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/25ab4136dd26
fix string conversion of enumeration value re WebIDL spec. r=bbouvier

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/25ab4136dd26