Closed Bug 1490310 Opened 2 years ago Closed 2 years ago

Intermitent /service-workers/service-worker/claim-worker-fetch.https.html | fetch() in nested Worker should be intercepted after the client is claimed. - expected FAIL

Categories

(Core :: DOM: Service Workers, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
geckoview62 --- unaffected
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 + fixed

People

(Reporter: aiakab, Assigned: ytausky)

Details

Attachments

(1 file)

Part of the log [task 2018-09-11T12:21:11.303Z] 12:21:11     INFO - TEST-OK | /html/infrastructure/urls/resolving-urls/query-encoding/location.sub.html?encoding=utf8 | took 731ms
[task 2018-09-11T12:21:11.304Z] 12:21:11     INFO - TEST-START | /html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251
[task 2018-09-11T12:21:11.360Z] 12:21:11     INFO - PID 7379 | [7379, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004005: file /builds/worker/workspace/build/src/docshell/shistory/nsSHistory.cpp, line 1357
[task 2018-09-11T12:21:11.361Z] 12:21:11     INFO - PID 7379 | [7379, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004005: file /builds/worker/workspace/build/src/docshell/shistory/nsSHistory.cpp, line 1357
[task 2018-09-11T12:21:11.402Z] 12:21:11     INFO - PID 7379 | ++DOCSHELL 0xdebef800 == 24 [pid = 7379] [id = {b834935b-1fe1-4cd0-bd78-3d557a91e4b8}]
[task 2018-09-11T12:21:11.403Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 63 (0xdf7a8820) [pid = 7379] [serial = 63] [outer = (nil)]
[task 2018-09-11T12:21:11.404Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 64 (0xdebf3c00) [pid = 7379] [serial = 64] [outer = 0xdf7a8820]
[task 2018-09-11T12:21:11.466Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 65 (0xdebf5c00) [pid = 7379] [serial = 65] [outer = 0xdf7a8820]
[task 2018-09-11T12:21:11.664Z] 12:21:11     INFO - PID 7379 | ++DOCSHELL 0xdf78bc00 == 25 [pid = 7379] [id = {38d13b62-472d-473d-82e7-29c4796aec88}]
[task 2018-09-11T12:21:11.664Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 66 (0xdfc51ee0) [pid = 7379] [serial = 66] [outer = (nil)]
[task 2018-09-11T12:21:11.666Z] 12:21:11     INFO - PID 7379 | ++DOCSHELL 0xdf791400 == 26 [pid = 7379] [id = {05f54234-5544-482e-a13b-1d72c3f54b86}]
[task 2018-09-11T12:21:11.666Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 67 (0xdfc53040) [pid = 7379] [serial = 67] [outer = (nil)]
[task 2018-09-11T12:21:11.668Z] 12:21:11     INFO - PID 7379 | ++DOCSHELL 0xdf791800 == 27 [pid = 7379] [id = {10e8d6b9-62fc-4104-9b40-30b3ee8075dd}]
[task 2018-09-11T12:21:11.669Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 68 (0xdfc53280) [pid = 7379] [serial = 68] [outer = (nil)]
[task 2018-09-11T12:21:11.670Z] 12:21:11     INFO - PID 7379 | ++DOCSHELL 0xdf791c00 == 28 [pid = 7379] [id = {d84f93d7-561f-4df7-b704-dec64c47a51b}]
[task 2018-09-11T12:21:11.670Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 69 (0xdfc533a0) [pid = 7379] [serial = 69] [outer = (nil)]
[task 2018-09-11T12:21:11.674Z] 12:21:11     INFO - PID 7379 | ++DOCSHELL 0xe038c000 == 29 [pid = 7379] [id = {bd1c69b9-279c-48bd-877b-9fd38da4a30b}]
[task 2018-09-11T12:21:11.674Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 70 (0xdfc535e0) [pid = 7379] [serial = 70] [outer = (nil)]
[task 2018-09-11T12:21:11.678Z] 12:21:11     INFO - PID 7379 | ++DOCSHELL 0xe0394400 == 30 [pid = 7379] [id = {98debf1c-3a41-435b-b232-73a4e63ef793}]
[task 2018-09-11T12:21:11.678Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 71 (0xdfc53820) [pid = 7379] [serial = 71] [outer = (nil)]
[task 2018-09-11T12:21:11.694Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 72 (0xdd2d1c00) [pid = 7379] [serial = 72] [outer = 0xdfc51ee0]
[task 2018-09-11T12:21:11.710Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 73 (0xdd2d2800) [pid = 7379] [serial = 73] [outer = 0xdfc53040]
[task 2018-09-11T12:21:11.718Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 74 (0xdd2d3400) [pid = 7379] [serial = 74] [outer = 0xdfc53280]
[task 2018-09-11T12:21:11.734Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 75 (0xdd2d4400) [pid = 7379] [serial = 75] [outer = 0xdfc533a0]
[task 2018-09-11T12:21:11.750Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 76 (0xdd2d5000) [pid = 7379] [serial = 76] [outer = 0xdfc535e0]
[task 2018-09-11T12:21:11.778Z] 12:21:11  WARNING - Traceback (most recent call last):
[task 2018-09-11T12:21:11.779Z] 12:21:11  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 312, in __call__
[task 2018-09-11T12:21:11.780Z] 12:21:11  WARNING -     rv = self.func(request, response)
[task 2018-09-11T12:21:11.780Z] 12:21:11  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/html/infrastructure/urls/resolving-urls/query-encoding/resources/resource.py", line 8, in main
[task 2018-09-11T12:21:11.781Z] 12:21:11  WARNING -     q = re.search(r'q=([^&]+)', request.url_parts.query).groups()[0]
[task 2018-09-11T12:21:11.781Z] 12:21:11  WARNING - AttributeError: 'NoneType' object has no attribute 'groups'
[task 2018-09-11T12:21:11.781Z] 12:21:11  WARNING - 
[task 2018-09-11T12:21:11.789Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 77 (0xdd2d9c00) [pid = 7379] [serial = 77] [outer = 0xdfc53820]
[task 2018-09-11T12:21:11.828Z] 12:21:11  WARNING - Traceback (most recent call last):
[task 2018-09-11T12:21:11.828Z] 12:21:11  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 312, in __call__
[task 2018-09-11T12:21:11.828Z] 12:21:11  WARNING -     rv = self.func(request, response)
[task 2018-09-11T12:21:11.828Z] 12:21:11  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/html/infrastructure/urls/resolving-urls/query-encoding/resources/resource.py", line 8, in main
[task 2018-09-11T12:21:11.828Z] 12:21:11  WARNING -     q = re.search(r'q=([^&]+)', request.url_parts.query).groups()[0]
[task 2018-09-11T12:21:11.828Z] 12:21:11  WARNING - AttributeError: 'NoneType' object has no attribute 'groups'
[task 2018-09-11T12:21:11.829Z] 12:21:11  WARNING - 
[task 2018-09-11T12:21:11.829Z] 12:21:11     INFO - PID 7379 | ++DOMWINDOW == 78 (0xdd2db400) [pid = 7379] [serial = 78] [outer = 0xdfc51ee0]
[task 2018-09-11T12:21:11.832Z] 12:21:11  WARNING - Traceback (most recent call last):
[task 2018-09-11T12:21:11.833Z] 12:21:11  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 312, in __call__
[task 2018-09-11T12:21:11.833Z] 12:21:11  WARNING -     rv = self.func(request, response)
[task 2018-09-11T12:21:11.834Z] 12:21:11  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/html/infrastructure/urls/resolving-urls/query-encoding/resources/resource.py", line 8, in main
[task 2018-09-11T12:21:11.834Z] 12:21:11  WARNING -     q = re.search(r'q=([^&]+)', request.url_parts.query).groups()[0]
[task 2018-09-11T12:21:11.836Z] 12:21:11  WARNING - AttributeError: 'NoneType' object has no attribute 'groups'
[task 2018-09-11T12:21:11.837Z] 12:21:11  WARNING - 
[task 2018-09-11T12:21:11.837Z] 12:21:11  WARNING - Traceback (most recent call last):
[task 2018-09-11T12:21:11.838Z] 12:21:11  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 312, in __call__
[task 2018-09-11T12:21:11.838Z] 12:21:11  WARNING -     rv = self.func(request, response)
[task 2018-09-11T12:21:11.839Z] 12:21:11  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/html/infrastructure/urls/resolving-urls/query-encoding/resources/resource.py", line 8, in main
[task 2018-09-11T12:21:11.839Z] 12:21:11  WARNING -     q = re.search(r'q=([^&]+)', request.url_parts.query).groups()[0]
[task 2018-09-11T12:21:11.840Z] 12:21:11  WARNING - AttributeError: 'NoneType' object has no attribute 'groups'
[task 2018-09-11T12:21:11.840Z] 12:21:11  WARNING - 
[task 2018-09-11T12:21:11.841Z] 12:21:11  WARNING - Traceback (most recent call last):
[task 2018-09-11T12:21:11.841Z] 12:21:11  WARNING -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 312, in __call__
[task 2018-09-11T12:21:11.842Z] 12:21:11  WARNING -     rv = self.func(request, response)
[task 2018-09-11T12:21:11.842Z] 12:21:11  WARNING -   File "/builds/worker/workspace/build/tests/web-platform/tests/html/infrastructure/urls/resolving-urls/query-encoding/resources/resource.py", line 8, in main
[task 2018-09-11T12:21:11.842Z] 12:21:11  WARNING -     q = re.search(r'q=([^&]+)', request.url_parts.query).groups()[0]
[task 2018-09-11T12:21:11.843Z] 12:21:11  WARNING - AttributeError: 'NoneType' object has no attribute 'groups'
Priority: -- → P3
Cleanup code in that test looks really messed up. I'll improve it a bit and hopefully this problem would go away.
Assignee: nobody → ytausky
Status: NEW → ASSIGNED
This test tried to clean up after itself, but didn't do a very good
job at it. I didn't analyze it fully, but I suspect that the ordering
of the microtasks in the test depended on a race condition that caused
it to fail from time to time. This commit moves cleanup code to the
test harness, which does a better job at ensuring that things happen
in order.
Comment on attachment 9013276 [details]
Bug 1490310: Fix cleanup code in claim-worker-fetch.https.html

Perry Jiang [:perry] has approved the revision.
Attachment #9013276 - Flags: review+
Comment on attachment 9013276 [details]
Bug 1490310: Fix cleanup code in claim-worker-fetch.https.html

Andrew Sutherland [:asuth] has approved the revision.
Attachment #9013276 - Flags: review+
Pushed by bugmail@asutherland.org:
https://hg.mozilla.org/integration/autoland/rev/677786af2188
Fix cleanup code in claim-worker-fetch.https.html r=asuth,perry
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13301 for changes under testing/web-platform/tests
https://hg.mozilla.org/mozilla-central/rev/677786af2188
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.