Closed
Bug 1490325
Opened 6 years ago
Closed 6 years ago
Write sccache log directly to artifact directory
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox-esr60 fixed, firefox64 fixed)
RESOLVED
FIXED
mozilla64
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(2 files)
We've seen some sccache failures that are hard to diagnose because currently the sccache log gets copied to the artifact directory only after a successful build. I believe this was mostly so that we could gzip it for uploading, but the logs aren't that big anyway, and some Taskcluster client implementations will store .log artifacts gzip-compressed, so I don't think we should worry about that detail.
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a69245c8eae000e9594f2a87662c8f01ffd35dd
Assignee | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=70d56b46ec6f221a9693d7404849b12d81bc5ae3
Assignee | ||
Comment 3•6 years ago
|
||
Still working out some kinks here, apparently nothing creates the artifact directory before the start of the build, and my attempt to do so on Windows didn't work properly, but one positive result here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=70d56b46ec6f221a9693d7404849b12d81bc5ae3&selectedJob=198690831 This job timed out in mozharness but produced an sccache.log. Less successful: https://treeherder.mozilla.org/#/jobs?repo=try&revision=70d56b46ec6f221a9693d7404849b12d81bc5ae3&selectedJob=198690813 This job hit "[taskcluster:error] Task timeout after 3600 seconds. Force killing container.", so it didn't upload any artifacts. :-/
Assignee | ||
Comment 4•6 years ago
|
||
I don't see anything suspicious in that sccache.log, except for the fact that we're not caching any compiles (bug 1484897 comment 11).
Assignee | ||
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed757b1c62776d890a28dba86ccd8160ddd0a045
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c8b3cb202aa8e8695174af6906041f82b656028
Assignee | ||
Comment 7•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d375c88a83552ca5c6620471ae87467e59188bfc
Assignee | ||
Comment 8•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1830176bd81896bc2716e48616813f9b114f9b08
Assignee | ||
Comment 9•6 years ago
|
||
Currently the BuildScript mozharness base class has an `ensure_upload_path` action that we run after the build. This patch changes it to no longer be an action, and instead simply run as part of `preflight_build` so that the artifact directory will be created before starting the build. This makes it more straightforward to write things like log files directly into this directory without worrying about whether it exists.
Assignee | ||
Comment 10•6 years ago
|
||
This patch makes it so we write the sccache log directly to the artifact directory, so that it will be uploaded even if the build fails. It also makes the log slightly more verbose. Both of these should help with diagnosing sccache failures in CI. The sccache log will no longer be explicitly gzip compressed, but some Taskcluster client implementations will store it as gzip compressed.
Assignee | ||
Comment 11•6 years ago
|
||
The last try push shows this mostly working, although the caveat in comment 3 about taskcluster timeouts still apply. (The try push includes an sccache update that is causing the timeouts.)
Comment 12•6 years ago
|
||
Comment on attachment 9010022 [details] bug 1490325 - make mozharness BuildScript.ensure_upload_path part of preflight_build. r?build Nick Alexander :nalexander [he/him] has approved the revision.
Attachment #9010022 -
Flags: review+
Comment 13•6 years ago
|
||
Comment on attachment 9010024 [details] bug 1490325 - write sccache log directly to artifact directory, make logs slightly more verbose. r?build Michael Shal [:mshal] has approved the revision.
Attachment #9010024 -
Flags: review+
Comment 14•6 years ago
|
||
Pushed by tmielczarek@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1ab93555c039 make mozharness BuildScript.ensure_upload_path part of preflight_build. r=firefox-build-system-reviewers,nalexander https://hg.mozilla.org/integration/autoland/rev/0780fdf31ce1 write sccache log directly to artifact directory, make logs slightly more verbose. r=mshal
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1ab93555c039 https://hg.mozilla.org/mozilla-central/rev/0780fdf31ce1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 16•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/c24daedcb748 https://hg.mozilla.org/releases/mozilla-esr60/rev/a547fcbc6c11
status-firefox-esr60:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•