Closed Bug 1490344 (gtktitlebardefault) Opened 2 years ago Closed 2 years ago

[Linux/Gtk] Enable hidden system titlebar by default

Categories

(Core :: Widget: Gtk, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
relnote-firefox --- 66+
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Depends on 2 open bugs, Blocks 1 open bug)

Details

(Keywords: feature)

Attachments

(1 file)

We may hide system titlebar by default at least on some well tested and recent enough platforms (Gnome derivates and Gtk+ > 3.20).
This patch implements -moz-gtk-csd-hide-titlebar-by-default media query
to check if the system titlebar should be disabled by default on Linux systems
(it's already disabled on Window/Mac).

It also removes explicit definition of browser.tabs.drawInTitlebar preference on Linux.
When browser.tabs.drawInTitlebar is missing the -moz-gtk-csd-hide-titlebar-by-default
is used to obtain the titlebar state. When browser.tabs.drawInTitlebar is set
in about:config or by Customize menu, the user peference is used instead of the default.

It also fixes a -moz-gtk-csd-available media query,
it was always true regardless the actual system setting.
Assignee: nobody → stransky

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa442da7cfd8
[Linux/Gtk] Enable hidden system titlebar by default on Gnome, r=dao

Keywords: checkin-needed

Should be fixed now, Thanks.

Flags: needinfo?(stransky)
Keywords: checkin-needed

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb3ca443d8c3
[Linux/Gtk] Enable hidden system titlebar by default on Gnome, r=dao

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Depends on: 1521010
Depends on: 1521012

Release Note Request (optional, but appreciated)
[Why is this notable]: User facing change
[Affects Firefox for Android]: No, Linux only
[Suggested wording]: System titlebar is hidden by default to match Gnome guideline (I invented the last one)
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?
Depends on: 1521039
No longer depends on: 1521010
Depends on: 1519606

I went with this wording for Nightly notes:
On Linux the Title Bar is now merged with the Tab Bar by default. This new behavior can be modified via the Customize… item in the main menu.

After this change, whenever I start Firefox, the right-click dropdown menu and the autoscroll wheel appear about a titlebar's height below and to the right of the cursor position. It corrects itself once resize the window.

Bug 1521175 describes a regression from this change.

Alias: gtktitlebardefault

Bug 1529713 needs to be backported to FF66 or this bug should be reverted for FF66 due to regressions listed here.

Noted for 66 as "System title bar is hidden by default to match Gnome guideline for Linux users"

You need to log in before you can comment on or make changes to this bug.