1490344 - (gtktitlebardefault) [Linux/Gtk] Enable hidden system titlebar by default

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (back on Jul 20)]

We may hide system titlebar by default at least on some well tested and recent enough platforms (Gnome derivates and Gtk+ > 3.20).

Comment 1

[Martin Stránský [:stransky] (back on Jul 20)]

Attachment: Bug 1490344 - [Linux/Gtk] Enable hidden system titlebar by default on Gnome, r=dao

This patch implements -moz-gtk-csd-hide-titlebar-by-default media query
to check if the system titlebar should be disabled by default on Linux systems
(it's already disabled on Window/Mac).

It also removes explicit definition of browser.tabs.drawInTitlebar preference on Linux.
When browser.tabs.drawInTitlebar is missing the -moz-gtk-csd-hide-titlebar-by-default
is used to obtain the titlebar state. When browser.tabs.drawInTitlebar is set
in about:config or by Customize menu, the user peference is used instead of the default.

It also fixes a -moz-gtk-csd-available media query,
it was always true regardless the actual system setting.

Comment 2

[Martin Stránský [:stransky] (back on Jul 20)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=71e0209d2b7995a715604662b06ba6a3f6764d41

Comment 3

[Martin Stránský [:stransky] (back on Jul 20)]

Try for all arches:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8da35f7f26881f57716f4b4a67d68183d6e1a46d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa442da7cfd8
[Linux/Gtk] Enable hidden system titlebar by default on Gnome, r=dao

Comment 5

[Andreea Pavel [:apavel]]

Backed out for failing bc at browser/components/customizableui/test/browser_970511_undo_restore_default.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=222179575&revision=aa442da7cfd82aeb542d30231e092c5e2491420a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222179575&repo=autoland&lineNumber=6344

Backout: https://hg.mozilla.org/integration/autoland/rev/475348be3c9463b96ee614c44afe33e3db17e960

Comment 6

[Martin Stránský [:stransky] (back on Jul 20)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b30ab990f84328ef9b9f0443b18c2525107e829

Comment 7

[Martin Stránský [:stransky] (back on Jul 20)]

Should be fixed now, Thanks.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb3ca443d8c3
[Linux/Gtk] Enable hidden system titlebar by default on Gnome, r=dao

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cb3ca443d8c3

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Release Note Request (optional, but appreciated)
[Why is this notable]: User facing change
[Affects Firefox for Android]: No, Linux only
[Suggested wording]: System titlebar is hidden by default to match Gnome guideline (I invented the last one)
[Links (documentation, blog post, etc)]:

Comment 11

[Pascal Chevrel:pascalc]

I went with this wording for Nightly notes:
On Linux the Title Bar is now merged with the Tab Bar by default. This new behavior can be modified via the Customize… item in the main menu.

Comment 12

[Ori Avtalion (salty-horse)]

After this change, whenever I start Firefox, the right-click dropdown menu and the autoscroll wheel appear about a titlebar's height below and to the right of the cursor position. It corrects itself once resize the window.

Comment 13

[Ori Avtalion (salty-horse)]

Bug 1521175 describes a regression from this change.

Comment 14

[Martin Stránský [:stransky] (back on Jul 20)]

Bug 1529713 needs to be backported to FF66 or this bug should be reverted for FF66 due to regressions listed here.

Comment 15

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Noted for 66 as "System title bar is hidden by default to match Gnome guideline for Linux users"