1490348 - Improve CacheIR Spew for Arrays

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

In Bug 1488786 there's an example of the current CacheIR Spew for arrays: 

>   "base":{
>     "type":"Array",
>     "value":"158d7a634d0 (shape: 158ec982290)"
>   },

This really doesn't tell us enough about the arrays to help us diagnose why an IC may not attach: Does the array have dense elements, is the indexed flag set, etc. 

It would be helpful if we output some more information to ease determination.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1490348 - Improve CacheIR Spew for arrays r?evilpie

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Here's a sample of the output for an Array object: 

> {
>   "name":"GetElem",
>   "file":"../jit-test/tests/cacheir/getelem-number.js",
>   "mode":0,
>   "line":9,
>   "column":4,
>   "pc":"105dc8716",
>   "base":{
>     "type":"Array",
>     "value":{
>       "shape":"105aaebf0",
>       "indexed":{
>         "denseInitializedLength":"2",
>         "denseCapacity":"2046"
>       }
>     }
>   },
>   "property":{
>     "type":"int32",
>     "value":12
>   }
> },

I'm open to changing this representation tho!

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

(to compare and contrast, an un-indexed object will still look like this) 

> {
>   "name":"SetElem",
>   "file":"../jit-test/tests/cacheir/setelem-dense-ooo.js",
>   "mode":0,
>   "line":8,
>   "column":22,
>   "pc":"106ce1bde",
>   "base":{
>     "type":"Array",
>     "value":"1067004c0 (shape: 1068b0078)"
>   },
>   "property":{
>     "type":"int32",
>     "value":0
>   },
>   "value":{
>     "type":"value"
>   }
> },

Comment 4

[Tom S [:evilpie]]

Comment on attachment 9009644 [details]
Bug 1490348 - Improve CacheIR Spew for arrays r?evilpie

Tom Schuster [:evilpie] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3d6fb688839
Improve CacheIR Spew for arrays r=evilpie

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e3d6fb688839