Closed
Bug 149036
Opened 23 years ago
Closed 23 years ago
Javascript windows zoom button is not enabled. Window has no minimum bounds
Categories
(Core Graveyard :: Embedding: Mac, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: moconnell, Assigned: ccarlen)
Details
(Keywords: topembed)
Attachments
(1 file, 1 obsolete file)
2.45 KB,
patch
|
mikepinkerton
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
When CWindowCreator creates a new chrome window, the window is
created with an inactive zoom button. Also, the window has no minimum
bounds. As a result the window can be resized to nothing.
Assignee | ||
Comment 1•23 years ago
|
||
Taking.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → mozilla1.0.1
Assignee | ||
Comment 2•23 years ago
|
||
This implements zooming as PowerPlant intends it to work. When zooming out, the
window is placed with the minimum amount of repositioning required to make the
whole window fit onscreen. I guess they really wish to enforce this convention
because you can set a standard *dimension* of an LWindow not a *rect*
Need r=
Assignee | ||
Comment 3•23 years ago
|
||
Updated patch uses the bounds of the gray rgn to determine the max size rather
than the size of the zoomed out (standard) rect.
Attachment #86260 -
Attachment is obsolete: true
Comment 4•23 years ago
|
||
Comment on attachment 86272 [details] [diff] [review]
patch v2
r=pink
Attachment #86272 -
Flags: review+
Assignee | ||
Comment 5•23 years ago
|
||
Missed something: The 1st occurance of
+ minMaxBounds.left = kMinimumWindowDimension.width;
+ minMaxBounds.top = kMinimumWindowDimension.height;
needs to be removed. With that, Patrick, can you sr=?
Assignee | ||
Comment 6•23 years ago
|
||
Simon, since Patrick is away, can you sr= this?
Comment 7•23 years ago
|
||
Comment on attachment 86272 [details] [diff] [review]
patch v2
sr=sfraser
Attachment #86272 -
Flags: superreview+
Assignee | ||
Comment 8•23 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 10•22 years ago
|
||
-- Verified in trunk current build(20021017). When i create a new window it is
created with an active zoom button. the window also has minimum bounds.
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•