Closed Bug 1490431 Opened Last year Closed Last year

Check interval spinbuttons in Feed Subscriptions dialog not usable

Categories

(Thunderbird :: Message Reader UI, defect)

defect
Not set

Tracking

(thunderbird_esr6062+ fixed, thunderbird63 fixed, thunderbird64 fixed)

RESOLVED FIXED
Thunderbird 64.0
Tracking Status
thunderbird_esr60 62+ fixed
thunderbird63 --- fixed
thunderbird64 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

In Feed Subscriptions dialog the spinbuttons to set the check interval aren't usable. The bindings.css is missing.
Attached patch feed-subscriptions.patch (obsolete) — Splinter Review
TB 60 is affected too.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9008151 - Flags: review?(jorgk)
Attachment #9008151 - Flags: approval-comm-esr60?
Attachment #9008151 - Flags: approval-comm-beta?
Comment on attachment 9008151 [details] [diff] [review]
feed-subscriptions.patch

Review of attachment 9008151 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/extensions/newsblog/content/feed-subscriptions.xul
@@ +4,5 @@
>     - License, v. 2.0. If a copy of the MPL was not distributed with this
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  
>  <?xml-stylesheet href="chrome://messenger/skin/" type="text/css"?>
> +#ifndef MOZ_SUITE

Why does SM not want that? They do in other places, like:
https://dxr.mozilla.org/comm-central/search?q=messenger%2Fcontent%2Fbindings.css+file%3A*.xul+path%3Amailnews%2F&redirect=false
https://dxr.mozilla.org/comm-central/rev/2a29ee0adb310b54a6a2df72034953fed8f2b043/comm/mailnews/base/search/content/FilterEditor.xul#6
SM doesn't have a bindings.css. And if they have it wouldn't be in messenger.
A line slipped that shouldn't.
Attachment #9008173 - Flags: review?(jorgk)
Attachment #9008173 - Flags: approval-comm-esr60?
Attachment #9008173 - Flags: approval-comm-beta?
Fix for two shared files.
Attachment #9008174 - Flags: review?(jorgk)
Attachment #9008174 - Flags: approval-comm-esr60?
Attachment #9008174 - Flags: approval-comm-beta?
Attachment #9008151 - Attachment is obsolete: true
Attachment #9008151 - Flags: review?(jorgk)
Attachment #9008151 - Flags: approval-comm-esr60?
Attachment #9008151 - Flags: approval-comm-beta?
Comment on attachment 9008173 [details] [diff] [review]
feed-subscriptions.patch

More dysfunctional spinbuttons. Have we found them all yet?
Attachment #9008173 - Flags: review?(jorgk)
Attachment #9008173 - Flags: review+
Attachment #9008173 - Flags: approval-comm-esr60?
Attachment #9008173 - Flags: approval-comm-esr60+
Attachment #9008173 - Flags: approval-comm-beta?
Attachment #9008173 - Flags: approval-comm-beta+
Comment on attachment 9008174 [details] [diff] [review]
Bug1490431-ifdef.patch

Thanks, this will help with not having to fix SM on ESR 60 later.
Attachment #9008174 - Flags: review?(jorgk)
Attachment #9008174 - Flags: review+
Attachment #9008174 - Flags: approval-comm-esr60?
Attachment #9008174 - Flags: approval-comm-esr60+
Attachment #9008174 - Flags: approval-comm-beta?
Attachment #9008174 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/916fc0f72124
Add bindings.css stylesheet to feed-subscriptions.xul to fix the spinbuttons. r=jorgk
https://hg.mozilla.org/comm-central/rev/babac1433bfb
in files shared with SM, include bindings.css stylesheet only for TB. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
TB 60.1 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/2cf9b9adc2e96bd7e16c2ced0d35d3626e98a21f
https://hg.mozilla.org/releases/comm-esr60/rev/97caf7bd20530335e9f5f63ed064f63d1348484a

In the ESR, mailnews/base/search/content/FilterEditor.xul was missing bindings.css and the spinbuttons in the "Size (KB)" filter didn't work. They should work now.
Target Milestone: --- → Thunderbird 64.0

So it's rather disappointing that preprocessing was added here, after effort was spent to avoid and remove it from feeds (and many other places in general). Why wasn't onload css injection considered. A pp file must use mach build for any change, and that's much longer than a restart with purgecaches.

You need to log in before you can comment on or make changes to this bug.