Closed Bug 1490493 Opened 6 years ago Closed 6 years ago

Don't close session when restoring the same session in GeckoView

Categories

(GeckoView :: General, defect, P3)

Product:
GeckoView
Component:
General
Platform:
All
Android
Type:
defect

Tracking

(geckoview62 wontfix, firefox-esr60 wontfix, firefox62 wontfix, firefox63 fixed, firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
geckoview62 --- wontfix
firefox-esr60 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(2 files)

Bug 1490493 - 1. Return early if same session is being restored; r?droeh
46 bytes, text/x-phabricator-request
droeh
: review+
pascalc
: approval-mozilla-beta+
Details | Review
Bug 1490493 - 2. Add tests for GeckoView saving/restoring state; r?droeh
46 bytes, text/x-phabricator-request
droeh
: review+
Details | Review 
When GeckoView tries to restore the same session that it already has, it should do nothing instead of closing the session.
Restoring the same session that's already managed by the GeckoView
instance should be a no-op.
Add some tests for all scenarios that GeckoView encounters when it is
saving/restoring state.
Comment on attachment 9008228 [details]
Bug 1490493 - 1. Return early if same session is being restored; r?droeh

Dylan Roeh (:droeh) has approved the revision.
Attachment #9008228 - Flags: review+
Comment on attachment 9008229 [details]
Bug 1490493 - 2. Add tests for GeckoView saving/restoring state; r?droeh

Dylan Roeh (:droeh) has approved the revision.
Attachment #9008229 - Flags: review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a0955e0457a
1. Return early if same session is being restored; r=droeh
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab31927770b8
2. Add tests for GeckoView saving/restoring state; r=droeh
https://hg.mozilla.org/mozilla-central/rev/8a0955e0457a
https://hg.mozilla.org/mozilla-central/rev/ab31927770b8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Jim, does this session bug affect Focus? Should we uplift to GV 62 or 63 Beta?
status-firefox62: --- → wontfix
status-firefox63: affected → ?
status-firefox-esr60: --- → wontfix
status-geckoview62: --- → ?
Flags: needinfo?(nchen)
This bug follows bug 1484001, so it should be uplifted to 63 but not GV 62.
status-firefox63: ? → affected
status-geckoview62: ? → wontfix
Flags: needinfo?(nchen)
Comment on attachment 9008228 [details]
Bug 1490493 - 1. Return early if same session is being restored; r?droeh

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1484001
[User impact if declined]: The app might become not functional after backgrounding then foregrounding
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Very small patch to address the bug
[String changes made/needed]: None
Attachment #9008228 - Flags: approval-mozilla-beta?
Comment on attachment 9008228 [details]
Bug 1490493 - 1. Return early if same session is being restored; r?droeh

Low risk patch improving reliability of Fennec, approved for 63 Beta, thanks.
Attachment #9008228 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 64 → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: