1490496 - expose XPCOM FFI for rkv

Status: RESOLVED FIXED

(Toolkit :: General, enhancement, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

To ease use of rkv in Firefox/Gecko, we should expose an XPCOM FFI to it.

Comment 1

[Justin Dolske [:Dolske]]

What's RKV?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

rkv is a Rust interface to the LMDB key-value storage engine.  We vendored it into mozilla-central in bug 1445451, and we're investigating its use to replace a variety of the bespoke engines and formats for persisting data in Firefox (as documented in https://github.com/mozilla/firefox-data-store-docs).

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: Bug 1490496 - implement XPCOM FFI for key-value storage

MozReview-Commit-ID: JnQzXG581DW

Comment 4

[Lina Butler [:lina]]

Comment on attachment 9010443 [details]
Bug 1490496 - implement XPCOM FFI for key-value storage

Lina Cambridge (she/her) [:lina] has approved the revision.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Hey Myk, this has r+, should it land or is it waiting on other work?

Comment 6

[Myk Melez [:myk] [@mykmelez]]

(In reply to Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #5)
> Hey Myk, this has r+, should it land or is it waiting on other work?

Good question!  Lina reviewed parts of the revision and gave r+, but this is still awaiting review of the rest of the revision from Nika, who is the overall (blocking) reviewer for the changes; so this isn't quite ready to land yet.

I'm not quite how best to represent that in this bug.  Perhaps the simplest solution would be to remove the review+ flag on the attachment, since the Phabricator revision <https://phabricator.services.mozilla.com/D6328> is the source of truth for review status.  If I remember correctly, we recently updated our Phabricator installation to no longer set Bugzilla review flags in part because they can be misleading, as they are in this case.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9010443 [details]
Bug 1490496 - implement XPCOM FFI for key-value storage

Yeah, that's where my confusion came from. I see now that it's waiting on Nika's review on phabricator. Thanks for the reply :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/466f9c24e749
implement XPCOM FFI for key-value storage r=nika,lina,mossop

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/466f9c24e749