Closed Bug 1490496 Opened Last year Closed 10 months ago
expose XPCOM FFI for rkv
46 bytes, text/x-phabricator-request
|Details | Review|
To ease use of rkv in Firefox/Gecko, we should expose an XPCOM FFI to it.
Summary: expose general FFI for rkv → expose XPCOM FFI for rkv
rkv is a Rust interface to the LMDB key-value storage engine. We vendored it into mozilla-central in bug 1445451, and we're investigating its use to replace a variety of the bespoke engines and formats for persisting data in Firefox (as documented in https://github.com/mozilla/firefox-data-store-docs).
Comment on attachment 9010443 [details] Bug 1490496 - implement XPCOM FFI for key-value storage Lina Cambridge (she/her) [:lina] has approved the revision.
Hey Myk, this has r+, should it land or is it waiting on other work?
(In reply to Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #5) > Hey Myk, this has r+, should it land or is it waiting on other work? Good question! Lina reviewed parts of the revision and gave r+, but this is still awaiting review of the rest of the revision from Nika, who is the overall (blocking) reviewer for the changes; so this isn't quite ready to land yet. I'm not quite how best to represent that in this bug. Perhaps the simplest solution would be to remove the review+ flag on the attachment, since the Phabricator revision <https://phabricator.services.mozilla.com/D6328> is the source of truth for review status. If I remember correctly, we recently updated our Phabricator installation to no longer set Bugzilla review flags in part because they can be misleading, as they are in this case.
Comment on attachment 9010443 [details] Bug 1490496 - implement XPCOM FFI for key-value storage Yeah, that's where my confusion came from. I see now that it's waiting on Nika's review on phabricator. Thanks for the reply :)
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/466f9c24e749 implement XPCOM FFI for key-value storage r=nika,lina,mossop
You need to log in before you can comment on or make changes to this bug.