1490528 - Stop compiling shaders for our D3D11 Non-WR compositor if WR is enabled

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

This bug is created by Bug 1467189 Comment 5 .

We need to make sure that fallback from WR to D3D11 Non-WR compositor works if we stop doing it.

Comment 1

[Sotaro Ikeda [:sotaro]]

It seems that there are 2 ways to do it.
- [1] reset gpu process during fallback from WR to D3D11 Non-WR compositor
- [2] initialize shaders for our D3D11 Non-WR compositor during fallback from WR to D3D11 Non-WR compositor

Comment 2

[Sotaro Ikeda [:sotaro]]

I take a look.

Comment 3

[Sotaro Ikeda [:sotaro]]

Shaders for D3D11 Non-WR compositor is pre-loaded by DeviceManagerDx::PreloadAttachmentsOnCompositorThread(). Even when PreloadAttachmentsOnCompositorThread() is not called, the shaders are loaded synchronously.

Fallback from WR to D3D11 Non-WR compositor without re-creating gpu process happen only when WR causes error. It does not happen in normal situation. Then sync shaders load for D3D11 Non-WR compositor seems acceptable.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - do not preload attachments for D3D11 Non-WR compositor when WR is used

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=a577d53794208d31e1e3851705ce26567c6ddb48&newProject=try&newRevision=0cebb417cbb7ff43c6f17951f5da2b55ce247fd7&framework=1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bf2fd049433
do not preload attachments for D3D11 Non-WR compositor when WR is used r=mattwoodrow

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/1bf2fd049433