Closed
Bug 1490548
Opened 6 years ago
Closed 6 years ago
Always use braces for if/for/while statements in BinAST auto-generated code
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file, 1 obsolete file)
|
31.97 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
We should apply the same change as bug 1488698 to BinSource-auto.*
|
Assignee | |
Comment 1•6 years ago
|
||
applicable on top of bug 1479659 and bug 1472103.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #9008309 -
Attachment is obsolete: true
Attachment #9010497 -
Flags: review?(dteller)
Comment on attachment 9010497 [details] [diff] [review] Always use braces for if/for/while statements in BinAST auto-generated code Review of attachment 9010497 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #9010497 -
Flags: review?(dteller) → review+
|
|
Assignee | |
Comment 4•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/765542d6237ecf99af924f61485d7fe19f4f722c Bug 1490548 - Always use braces for if/for/while statements in BinAST auto-generated code r=Yoric
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/765542d6237e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•