mingw-clang x86 build does not configure because clang does not support --enable-stdcall-fixup

RESOLVED FIXED in Firefox -esr60

Status

defect
P5
normal
RESOLVED FIXED
9 months ago
2 months ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

Trunk
mozilla64
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr6064+ fixed, firefox64 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

9 months ago
No description provided.
Assignee

Comment 1

9 months ago
> lld: error: unknown argument: --enable-stdcall-fixup

Broken Build Example: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3bbba9f2e40ad115766e25e0969ef4c2e3118e6&selectedJob=198737678
Assignee

Comment 2

9 months ago
clang doesn't recognize --enable-stdcall-fixup as an option. We needed this for the
mingw-gcc build (added in Bug 787653) because gcc had difficulty dealing with
Angle's symbol linking
Comment on attachment 9009735 [details]
Bug 1490566 Do not pass --enable-stdcall-fixup to clang in a x86 Windows build r=froydnj

Nathan Froyd [:froydnj] has approved the revision.
Attachment #9009735 - Flags: review+
Assignee

Updated

9 months ago
Keywords: checkin-needed

Comment 4

9 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/a52a76a43b14
Do not pass --enable-stdcall-fixup to clang in a x86 Windows build r=froydnj
Keywords: checkin-needed

Comment 5

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a52a76a43b14
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee

Comment 6

8 months ago
Comment on attachment 9009735 [details]
Bug 1490566 Do not pass --enable-stdcall-fixup to clang in a x86 Windows build r=froydnj

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build patch needed to get Tor's mingw-clang build running on the esr60 branch.

User impact if declined: We won't be able to run mingwclang in automation and Tor will need to apply this patch themselves

Fix Landed on Version: 64.0a1 / 20180919123806

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Only affects the mingw-clang build

String or UUID changes made by this patch:
Attachment #9009735 - Flags: approval-mozilla-esr60?
Comment on attachment 9009735 [details]
Bug 1490566 Do not pass --enable-stdcall-fixup to clang in a x86 Windows build r=froydnj

OK for ESR60 uplift, support for (downstream) builds
Attachment #9009735 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+

Updated

2 months ago
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.