Closed
Bug 1490566
Opened 6 years ago
Closed 6 years ago
mingw-clang x86 build does not configure because clang does not support --enable-stdcall-fixup
Categories
(Firefox Build System :: General: Unsupported Platforms, defect, P5)
Firefox Build System
General: Unsupported Platforms
Tracking
(firefox-esr6064+ fixed, firefox64 fixed)
RESOLVED
FIXED
mozilla64
People
(Reporter: tjr, Assigned: tjr)
References
Details
Attachments
(1 file)
46 bytes,
text/x-phabricator-request
|
froydnj
:
review+
lizzard
:
approval-mozilla-esr60+
|
Details | Review |
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
> lld: error: unknown argument: --enable-stdcall-fixup
Broken Build Example: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3bbba9f2e40ad115766e25e0969ef4c2e3118e6&selectedJob=198737678
Assignee | ||
Comment 2•6 years ago
|
||
clang doesn't recognize --enable-stdcall-fixup as an option. We needed this for the
mingw-gcc build (added in Bug 787653) because gcc had difficulty dealing with
Angle's symbol linking
Comment 3•6 years ago
|
||
Comment on attachment 9009735 [details]
Bug 1490566 Do not pass --enable-stdcall-fixup to clang in a x86 Windows build r=froydnj
Nathan Froyd [:froydnj] has approved the revision.
Attachment #9009735 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/a52a76a43b14
Do not pass --enable-stdcall-fixup to clang in a x86 Windows build r=froydnj
Keywords: checkin-needed
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 9009735 [details]
Bug 1490566 Do not pass --enable-stdcall-fixup to clang in a x86 Windows build r=froydnj
[ESR Uplift Approval Request]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build patch needed to get Tor's mingw-clang build running on the esr60 branch.
User impact if declined: We won't be able to run mingwclang in automation and Tor will need to apply this patch themselves
Fix Landed on Version: 64.0a1 / 20180919123806
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Only affects the mingw-clang build
String or UUID changes made by this patch:
Attachment #9009735 -
Flags: approval-mozilla-esr60?
Updated•6 years ago
|
status-firefox-esr60:
--- → affected
tracking-firefox-esr60:
--- → 64+
Comment 7•6 years ago
|
||
Comment on attachment 9009735 [details]
Bug 1490566 Do not pass --enable-stdcall-fixup to clang in a x86 Windows build r=froydnj
OK for ESR60 uplift, support for (downstream) builds
Attachment #9009735 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Comment 8•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Priority: -- → P5
You need to log in
before you can comment on or make changes to this bug.
Description
•