Closed
Bug 1490600
Opened 7 years ago
Closed 7 years ago
Always use braces for if/for/while statements in XPConnect
Categories
(Core :: XPConnect, enhancement)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(6 files)
|
46 bytes,
text/x-phabricator-request
|
kmag
:
review+
|
Details |
|
46 bytes,
text/x-phabricator-request
|
bholley
:
review+
|
Details |
|
46 bytes,
text/x-phabricator-request
|
mccr8
:
review+
|
Details |
|
46 bytes,
text/x-phabricator-request
|
mccr8
:
review+
|
Details |
|
46 bytes,
text/x-phabricator-request
|
kmag
:
review+
|
Details |
|
46 bytes,
text/x-phabricator-request
|
bholley
:
review+
|
Details |
No description provided.
| Assignee | ||
Comment 1•7 years ago
|
||
The patches I'll post soon are 99% auto-generated and I think can be rubberstamped. (I also checked them myself several times.)
| Assignee | ||
Comment 2•7 years ago
|
||
| Assignee | ||
Comment 3•7 years ago
|
||
Depends on D5651
| Assignee | ||
Comment 4•7 years ago
|
||
Depends on D5652
| Assignee | ||
Comment 5•7 years ago
|
||
Depends on D5653
| Assignee | ||
Comment 6•7 years ago
|
||
Depends on D5654
| Assignee | ||
Comment 7•7 years ago
|
||
Depends on D5655
Comment 8•7 years ago
|
||
Comment on attachment 9008352 [details]
Bug 1490600 - Always use braces for if/for/while statements in js/xpconnect/wrappers. r?bholley
Bobby Holley (:bholley) has approved the revision.
Attachment #9008352 -
Flags: review+
Comment 9•7 years ago
|
||
Comment on attachment 9008348 [details]
Bug 1490600 - Always use braces for if/for/while statements in js/xpconnect/src, part 1. r?bholley
Bobby Holley (:bholley) has approved the revision.
Attachment #9008348 -
Flags: review+
Comment 10•7 years ago
|
||
Comment on attachment 9008349 [details]
Bug 1490600 - Always use braces for if/for/while statements in js/xpconnect/src, part 2. r?mccr8
Andrew McCreight [:mccr8] has approved the revision.
Attachment #9008349 -
Flags: review+
Comment 11•7 years ago
|
||
Comment on attachment 9008347 [details]
Bug 1490600 - Always use braces for if/for/while statements in js/xpconnect/loader. r?kmag
Kris Maglione [:kmag] has approved the revision.
Attachment #9008347 -
Flags: review+
Comment 12•7 years ago
|
||
Comment on attachment 9008350 [details]
Bug 1490600 - Always use braces for if/for/while statements in js/xpconnect/src, part 3. r?mccr8
Andrew McCreight [:mccr8] has approved the revision.
Attachment #9008350 -
Flags: review+
Comment 13•7 years ago
|
||
Comment on attachment 9008351 [details]
Bug 1490600 - Always use braces for if/for/while statements in js/xpconnect/src, part 4. r?kmag
Kris Maglione [:kmag] has approved the revision.
Attachment #9008351 -
Flags: review+
Comment 14•7 years ago
|
||
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c5a6202e80a0
Always use braces for if/for/while statements in js/xpconnect/loader. r=kmag
https://hg.mozilla.org/integration/autoland/rev/bc86dafc4ae2
Always use braces for if/for/while statements in js/xpconnect/src, part 1. r=bholley
https://hg.mozilla.org/integration/autoland/rev/5fbdba17f904
Always use braces for if/for/while statements in js/xpconnect/src, part 2. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/843c731503cc
Always use braces for if/for/while statements in js/xpconnect/src, part 3. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/3650f0f019d1
Always use braces for if/for/while statements in js/xpconnect/src, part 4. r=kmag
https://hg.mozilla.org/integration/autoland/rev/fa26c3594f36
Always use braces for if/for/while statements in js/xpconnect/wrappers. r=bholley
Comment 15•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c5a6202e80a0
https://hg.mozilla.org/mozilla-central/rev/bc86dafc4ae2
https://hg.mozilla.org/mozilla-central/rev/5fbdba17f904
https://hg.mozilla.org/mozilla-central/rev/843c731503cc
https://hg.mozilla.org/mozilla-central/rev/3650f0f019d1
https://hg.mozilla.org/mozilla-central/rev/fa26c3594f36
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•