1490677 - Crash in mozilla::ipc::WriteIPDLParam<T>

Status: RESOLVED DUPLICATE of bug 1443748

(Core :: IPC, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-628035cc-c828-47c3-b7c8-73fef0180908.
=============================================================

Seen while looking at nightly crash stats - 15 crashes/9 installs on 64 nightly in the last 7 days: https://bit.ly/2CLHtUE. Windows and Mac seem to be affected. This signature doesn't have large volume on 62.

Top 10 frames of crashing thread:

0 XUL void mozilla::ipc::WriteIPDLParam<mozilla::ipc::FileDescriptor&> ipc/glue/FileDescriptor.cpp:235
1 XUL std::__1::__function::__func<mozilla::net::PNeckoParent::OnMessageReceived ipc/ipdl/PNeckoParent.cpp:2397
2 XUL mozilla::net::ExtensionJARFileOpener::SendBackFD clang/include/c++/v1/functional:1916
3 XUL mozilla::detail::RunnableMethodImpl<mozilla::net::ExtensionJARFileOpener*, nsresult  xpcom/threads/nsThreadUtils.h:1178
4 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1161
5 XUL nsBaseAppShell::NativeEventCallback xpcom/threads/nsThreadUtils.cpp:461
6 XUL nsAppShell::ProcessGeckoEvents widget/cocoa/nsAppShell.mm:461
7 CoreFoundation CoreFoundation@0x80a00 
8 CoreFoundation CoreFoundation@0x72b8c 
9 CoreFoundation CoreFoundation@0x721be 

=============================================================

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Haik, you were looking at the JARFileOpener recently right?

Comment 2

[Haik Aftandilian [:haik]]

(In reply to Alex Gaynor [:Alex_Gaynor] from comment #1)
> Haik, you were looking at the JARFileOpener recently right?

Yeah, thanks. This looks like a dupe of bug 1443748.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Fixed in 63 in bug 1443748.

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

bug 1443748 was fixed but we are still seeing crashes on all channels, Haik is there a follow up to this bug to fix the remaining crashes?

Comment 5

[Andrew McCreight [:mccr8]]

I'll take a look and file some followup bugs. This signature is really generic so they are unlikely to be related to the initial issue.

Comment 6

[Haik Aftandilian [:haik]]

(In reply to Pascal Chevrel:pascalc from comment #4)

bug 1443748 was fixed but we are still seeing crashes on all channels, Haik is there a follow up to this bug to fix the remaining crashes?

No follow up needed for bug 1443748. But as Andrew said, the [@ mozilla::ipc::WriteIPDLParam<T> ] frame is so generic that it's the top frame in many other crashes. I looked at several of the crashes and none of them looked related to bug 1443748.

(In reply to Andrew McCreight [:mccr8] from comment #5)

I'll take a look and file some followup bugs. This signature is really generic so they are unlikely to be related to the initial issue.

Thanks!

Comment 7

[Andrew McCreight [:mccr8]]

(In reply to Pascal Chevrel:pascalc from comment #4)

bug 1443748 was fixed but we are still seeing crashes on all channels, Haik is there a follow up to this bug to fix the remaining crashes?

It looks like almost all of the remaining crashes for this and a related signature are some particular variant that went away during the 67 Nightly cycle. I filed bug 1543495 for that, but presumably there's nothing we can do at this point.

Comment 8

[Andrew McCreight [:mccr8]]

I guess that's not entirely true, but the crashes have almost all gone away in 67 onwards.