Closed Bug 1490745 Opened 6 years ago Closed 5 years ago

Intermittent browser_exit_background_customize_mode.js | Should not have a tab marked as being the customize tab now. - [object XULElement] == null - JS frame :: browser/components/customizableui/test/browser_exit_background_customize_mode.js

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 72
Tracking Flags:
Tracking Status
firefox-esr68 --- fixed
firefox71 --- fixed
firefox72 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Gijs)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(1 file)

Bug 1490745 - ensure we wait for the actual test page to finish loading, r?mconley
47 bytes, text/x-phabricator-request
Details | Review 
Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=198891440&repo=autoland

https://queue.taskcluster.net/v1/task/fnf34oBESxiDmDEirHTLkQ/runs/0/artifacts/public/logs/live_backing.log

16:28:19     INFO - TEST-START | browser/components/customizableui/test/browser_exit_background_customize_mode.js
16:28:19     INFO - TEST-INFO | started process screenshot
16:28:19     INFO - TEST-INFO | screenshot: exit 0
16:28:19     INFO - Buffered messages logged at 16:28:19
16:28:19     INFO - Entering test bound test_exit_background_customize_mode
16:28:19     INFO - TEST-PASS | browser/components/customizableui/test/browser_exit_background_customize_mode.js | Should not have a tab marked as being the customize tab now. - null == null - 
16:28:19     INFO - TEST-PASS | browser/components/customizableui/test/browser_exit_background_customize_mode.js | Should have 2 tabs - 
16:28:19     INFO - Buffered messages finished
16:28:19     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_exit_background_customize_mode.js | Should not have a tab marked as being the customize tab now. - [object XULElement] == null - JS frame :: chrome://mochitests/content/browser/browser/components/customizableui/test/browser_exit_background_customize_mode.js :: test_exit_background_customize_mode :: line 27
16:28:19     INFO - Stack trace:
16:28:19     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_exit_background_customize_mode.js:test_exit_background_customize_mode:27
16:28:19     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
16:28:19     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
16:28:19     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
16:28:19     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
16:28:19     INFO - Not taking screenshot here: see the one that was previously logged
16:28:19     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_exit_background_customize_mode.js | Should have 3 tabs now - Got 2, expected 3
16:28:19     INFO - Stack trace:
16:28:19     INFO - chrome://mochikit/content/browser-test.js:test_is:1304
16:28:19     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_exit_background_customize_mode.js:test_exit_background_customize_mode:32
16:28:19     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
16:28:19     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
16:28:19     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
16:28:19     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
16:28:19     INFO - Leaving test bound test_exit_background_customize_mode
16:28:19     INFO - GECKO(732) | MEMORY STAT | vsize 804MB | vsizeMaxContiguous 675MB | residentFast 317MB | heapAllocated 140MB
16:28:19     INFO - TEST-OK | browser/components/customizableui/test/browser_exit_background_customize_mode.js | took 658ms
Summary: Intermittent browser_exit_background_customize_mode.js | Should not have a tab marked as being the customize tab now. - [object XULElement] == null - JS frame :: chrome://mochitests/content/browser/browser/components/customizableui/test → Intermittent browser_exit_background_customize_mode.js | Should not have a tab marked as being the customize tab now. - [object XULElement] == null - JS frame :: browser/components/customizableui/test/browser_exit_background_customize_mode.js
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=215854509&repo=autoland&lineNumber=3255

23:47:31     INFO - TEST-START | browser/components/customizableui/test/browser_exit_background_customize_mode.js
23:47:32     INFO - TEST-INFO | started process screenshot
23:47:32     INFO - TEST-INFO | screenshot: exit 0
23:47:32     INFO - Buffered messages logged at 23:47:31
23:47:32     INFO - Entering test bound test_exit_background_customize_mode
23:47:32     INFO - TEST-PASS | browser/components/customizableui/test/browser_exit_background_customize_mode.js | Should not have a tab marked as being the customize tab now. - null == null - 
23:47:32     INFO - Buffered messages logged at 23:47:32
23:47:32     INFO - TEST-PASS | browser/components/customizableui/test/browser_exit_background_customize_mode.js | Should have 2 tabs - 
23:47:32     INFO - Buffered messages finished
23:47:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_exit_background_customize_mode.js | Should not have a tab marked as being the customize tab now. - [object XULElement] == null - JS frame :: chrome://mochitests/content/browser/browser/components/customizableui/test/browser_exit_background_customize_mode.js :: test_exit_background_customize_mode :: line 27
23:47:32     INFO - Stack trace:
23:47:32     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_exit_background_customize_mode.js:test_exit_background_customize_mode:27
23:47:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
23:47:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
23:47:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:982
23:47:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
23:47:32     INFO - Not taking screenshot here: see the one that was previously logged
23:47:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_exit_background_customize_mode.js | Should have 3 tabs now - Got 2, expected 3
23:47:32     INFO - Stack trace:
23:47:32     INFO - chrome://mochikit/content/browser-test.js:test_is:1303
23:47:32     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_exit_background_customize_mode.js:test_exit_background_customize_mode:32
23:47:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
23:47:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
23:47:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:982
23:47:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
23:47:32     INFO - Leaving test bound test_exit_background_customize_mode
23:47:32     INFO - GECKO(1676) | MEMORY STAT | vsize 807MB | vsizeMaxContiguous 669MB | residentFast 324MB | heapAllocated 148MB
23:47:32     INFO - TEST-OK | browser/components/customizableui/test/browser_exit_background_customize_mode.js | took 683ms
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Status: REOPENED → RESOLVED
Closed: 6 years ago → 5 years ago
Resolution: --- → INCOMPLETE

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → INCOMPLETE

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245395566&repo=autoland&lineNumber=2811

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → INCOMPLETE

Recent log failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258435156&repo=autoland&lineNumber=10777

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

Do we know when this regressed? The spikes in the graphs are on weekends (so unreliable, because there's much less data) which makes it tricky to work out, and without at least some clue as to what broke this it'll be difficult to do something about this.

Flags: needinfo?(ncsoregi)
Flags: needinfo?(apavel)

Looked at the graph and looked through the entries in Orange Factor.
The number of failures started increasing from the 8th of October mostly. Most failures were on try, on the beta-simulations we have made.
Beta-sim on the 8th of October https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbc64a86d5ef083dd2e88d999f119e1f9d07f0b0&searchStr=browser-chrome&group_state=expanded&selectedJob=272341430 and the first occurrence from 14 days ago, which corresponds to the following push on mozilla-central https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&group_state=expanded&searchStr=browser-chrome&revision=035f52aed4427b22facfa883067e298f10ef9e97 .
Unfortunately, the test is moving chunks and platforms and at this point I can't tell exactly what caused the failure rate to increase, but as far as I looked in OF I don't think this should be too concerning.
Maybe Andreea has more insight, or maybe she can look deeper into this.

Flags: needinfo?(ncsoregi)

Hi Alexander, can the spikes mentioned by Natalia above be from bug 1397876?

Flags: needinfo?(apavel) → needinfo?(surkov.alexander)

Brian can you answer the above?

Flags: needinfo?(bgrinstead)
Assignee: nobody → gijskruitbosch+bugs
Status: REOPENED → ASSIGNED
Flags: needinfo?(surkov.alexander)
Flags: needinfo?(bgrinstead)

The browserLoaded() promise can be resolved by about:blank loads, it seems.
Being explicit about the load we're waiting for fixes this issue.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8abc667b6b63
ensure we wait for the actual test page to finish loading, r=mconley
Keywords: leave-open

2 days on, 0 recurrences since this landed, gonna call this fixed.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox72: --- → fixed
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [stockwell needswork:owner] → [stockwell fixed]
Target Milestone: --- → Firefox 72
See Also: → 1592999

Can we uplift this test-only change ( https://hg.mozilla.org/integration/autoland/rev/8abc667b6b63 ) to beta? Looks like the clone bug 1592999 is about beta instances of this.

Flags: needinfo?(ryanvm)
Flags: needinfo?(ryanvm)
No longer blocks: 1592999
See Also: 1592999 →
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: