Closed Bug 1490776 Opened Last year Closed Last year

Sidebar properties that are arrays render as objects.

Categories

(DevTools :: Accessibility Tools, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed, firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: yzen, Assigned: yzen)

Details

Attachments

(1 file)

We need to use a noGrip property to fix the array rendering. Right now all array props show up as objects.
MozReview-Commit-ID: 4QAPbUBYiCW
Comment on attachment 9008502 [details]
Bug 1490776 - fix noGrip array rendering in a11y panel sidebar. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.
Attachment #9008502 - Flags: review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f039fc0bda93
fix noGrip array rendering in a11y panel sidebar. r=gl
Comment on attachment 9008502 [details]
Bug 1490776 - fix noGrip array rendering in a11y panel sidebar. r=gl

[Feature/Bug causing the regression]: There was a change in reps component that renders arrays which required an update on the a11y panel side.
[User impact if declined]: Array in the sidebar will look like objects are would be very confusing to the users.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet, locally. Queued for landing.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just a small property added in place where simple JS values are rendered in the properties sidebar.
[String changes made/needed]: None
Attachment #9008502 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/f039fc0bda93
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment on attachment 9008502 [details]
Bug 1490776 - fix noGrip array rendering in a11y panel sidebar. r=gl

Low-risk patch for a11y, uplift approved for 63 beta 6 thanks.
Attachment #9008502 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.