1490776 - Sidebar properties that are arrays render as objects.

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, enhancement)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

We need to use a noGrip property to fix the array rendering. Right now all array props show up as objects.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1490776 - fix noGrip array rendering in a11y panel sidebar. r=gl

MozReview-Commit-ID: 4QAPbUBYiCW

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9008502 [details]
Bug 1490776 - fix noGrip array rendering in a11y panel sidebar. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f039fc0bda93
fix noGrip array rendering in a11y panel sidebar. r=gl

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 9008502 [details]
Bug 1490776 - fix noGrip array rendering in a11y panel sidebar. r=gl

[Feature/Bug causing the regression]: There was a change in reps component that renders arrays which required an update on the a11y panel side.
[User impact if declined]: Array in the sidebar will look like objects are would be very confusing to the users.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet, locally. Queued for landing.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just a small property added in place where simple JS values are rendered in the properties sidebar.
[String changes made/needed]: None

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/f039fc0bda93

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9008502 [details]
Bug 1490776 - fix noGrip array rendering in a11y panel sidebar. r=gl

Low-risk patch for a11y, uplift approved for 63 beta 6 thanks.

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/263df0c4e8e4