1490794 - Add profiling stack frame for script compilation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Markus Stange [:mstange]]

Example profile: https://perfht.ml/2x7MwcN

Bug 1478393 added profiling frames for script parse and script emit but we don't have frames for script compilation yet. We should add them.

for example js::jit::IonCompileScriptForBaseline or js::jit::Compile

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1490794 - Add profiling stack frame for script compilation r?sfink

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

I added the stack frame to `js::jit::Compile` instead of `js::jit::IonCompileScriptForBaseline` since `Compile` is used by this and there are other methods that use `Compile` like `Recompile`.

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

The new stack frame can be seen here:
https://perf-html.io/public/7acb0ca7d1caa65d035bd79087f1ed0476505c1f/calltree/?globalTrackOrder=0-1-2-3-4-5&hiddenGlobalTracks=1-3&localTrackOrderByPid=68758-1-0~68762-0~&search=script%20compiling&thread=6&v=3

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 9009107 [details]
Bug 1490794 - Add profiling stack frame for script compilation r?sfink

Jan de Mooij [:jandem] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9e9863b9e20
Add profiling stack frame for script compilation r=jandem

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c9e9863b9e20