Closed Bug 1490794 Opened Last year Closed Last year

Add profiling stack frame for script compilation

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mstange, Assigned: canaltinova)

Details

Attachments

(1 file)

Example profile: https://perfht.ml/2x7MwcN

Bug 1478393 added profiling frames for script parse and script emit but we don't have frames for script compilation yet. We should add them.

for example js::jit::IonCompileScriptForBaseline or js::jit::Compile
Assignee: nobody → canaltinova
Status: NEW → ASSIGNED
I added the stack frame to `js::jit::Compile` instead of `js::jit::IonCompileScriptForBaseline` since `Compile` is used by this and there are other methods that use `Compile` like `Recompile`.
Comment on attachment 9009107 [details]
Bug 1490794 - Add profiling stack frame for script compilation r?sfink

Jan de Mooij [:jandem] has approved the revision.
Attachment #9009107 - Flags: review+
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c9e9863b9e20
Add profiling stack frame for script compilation r=jandem
https://hg.mozilla.org/mozilla-central/rev/c9e9863b9e20
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.