Closed Bug 1490867 Opened 2 years ago Closed 2 years ago

After Bug 1490765 replace configure.in with moz.configure stuff

Categories

(MailNews Core :: Build Config, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: iann_bugzilla, Assigned: rjl)

References

Details

(Whiteboard: [Thunderbird-temporary-fix])

Attachments

(4 files)

After Bug 1490765 the configure.in in mail and suite will no longer get called but according to glandium (https://bugzilla.mozilla.org/show_bug.cgi?id=1490765#c4) it can be replaced by moz.configure stuff
Depends on: 1479904, 1481067
The equivalent of Bug 1481067 needs to be done for calendar/ and mail/ to remove the *dir in configure.in (probably in Bug 
1479904)
Pattern matching attempt ;-)
Keywords: leave-open
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f3343302b310
Temporarily hack build. rs=bustage-fix DONTBUILD
Hack works for SeaMonkey too. Thanks Jorg and Bill.
Attachment #9009427 - Flags: review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/d0a694c28bf8
Hack SeaMonkey build until fallout from Bug 1490765 is properly fixed. r=frg
Whiteboard: [Thunderbird-temporary-fix]
Assignee: nobody → rob
Ready for review? Then please ask Philipp (:Fallen).
Patch is a work in progress. It builds in my local dev environment, but fails on the try server. Just posting the patch so I don't accidentally lose my work again.
Patch is ready for review. A build completed successfully on try for linux, linux64, macosx, win32, and win64. I'm running a second build that will also run our tests.
From the conversation in Phabricator:

Fallen added a comment.Sun, Oct 7, 8:45 AM
I'm not sure we should get rid of commtopsrcdir and moztopsrcdir. When I created those initially I wanted comm-central to be very explicit about what it is referencing. Someone reading topsrcdir might assume comm-central and do the wrong thing. Can we clean up whatever subconfigure is left but keep the explicit variable names?


rjl added a comment.Sun, Oct 7, 2:47 PM
I can do that... but the way I interpreted the bug, the desire was to get rid of those variables.
https://bugzilla.mozilla.org/show_bug.cgi?id=1490867#c1 -
The equivalent of Bug 1481067 needs to be done for calendar/ and mail/ to remove the *dir in configure.in
Bug 1481067 is the same work as this but for the SeaMonkey code. That bug was resolved a while back, and Frank removed all of the comm* and moz* variables. For consistencies sake, we can either follow suit or convince him to update his code again.
Getting rid of configure.in is proving to be challenging.

The current problem I'm running into is setting the values for moztopsrcdir, commtopsrc, etc.  Right now those are created as environment variables in confvars.sh, and then are saved as AC_SUBST variables.

moz.configure is up to the task. The problem I'm having is confvars.sh doesn't seem to get read early enuough for moz.configure to be able to make use of it. The environment variable vales themselves are not difficult to calculate them.

This may prove to be problemtic as we're no longer workng off environmnt variables that exist prior to running configure.
While completing the migration to moz.configure, a couple of build errors came
up that may be related. This patch fixes the errors in question.

Depends on D7629
(In reply to Rob Lemley [:rjl] from comment #14)
> Successful try build last night:
> https://treeherder.mozilla.org/#/jobs?repo=try-comm-
> central&revision=3af15762c2b7bceccc7392aebcf51b34687cb722

Ran another try build hitting all platforms. Some unrelated(?) test failures, otherwise looks good.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&selectedJob=206236984
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 64.0
Version: Trunk → 64
Landing this later today when the Windows bustage is fixed.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0a3049206774
replace configure.in with moz.configure. r=philipp
https://hg.mozilla.org/comm-central/rev/2506123465df
Build fixes for moz.configure. r=philipp
Status: NEW → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Just an NI for myself to look into this later for suite.
Flags: needinfo?(frgrahl)

Filed Bug 1519872 as a follow-up for suite.

Flags: needinfo?(frgrahl)
You need to log in before you can comment on or make changes to this bug.