Closed Bug 1490942 Opened Last year Closed Last year

WebRender not qualified for desktops with UPS ("Has battery")

Categories

(Core :: Graphics: WebRender, defect, P2)

Desktop
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 --- disabled
firefox65 --- fixed

People

(Reporter: mayhemer, Assigned: aosmond)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Win10 desktop with a UPS connected, current nightly (before bug 1490742, double checked)

about:support says:

Compositing	Direct3D 11 (Advanced Layers)

WEBRENDER	
opt-in by default: WebRender is an opt-in feature

WEBRENDER_QUALIFIED	
blocked by env: Has battery


As the machine is a desktop with an NVidia card, it can be enabled by default.
Caused by bug 1477036 and bug 1475355.
https://technet.microsoft.com/en-us/library/cc180825.aspx
https://www.howtogeek.com/241706/can-software-differentiate-between-a-desktop-computer-and-a-laptop/
Blocks: 1475355
Keywords: regression
OS: Unspecified → Windows 10
Hardware: Unspecified → Desktop
Summary: WebRenderer not qualified for desktops with UPS ("Has battery") → WebRender not qualified for desktops with UPS ("Has battery")
https://docs.microsoft.com/en-us/windows/desktop/power/enumerating-battery-devices
https://docs.microsoft.com/en-us/windows/desktop/power/battery-information-str

Looks like we need to call a bunch of APIs to check the BATTERY_IS_SHORT_TERM flag which indicates if it is a UPS?
aosmond will take this up when he's free.
At this point, I'm assuming that will be next week, unless I solve the memory issues faster than I expect :).
Priority: P2 → P3
Priority: P3 → P2
In progress.
Assignee: nobody → aosmond
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=50603da8ab2babfdf62e560e0b3bbe6780cf249e&selectedJob=204530849

I don't have a UPS to test with, although I confirmed with the reference machine that we still get WebRender without any battery :). Could you please try the debug build from https://queue.taskcluster.net/v1/task/I-XJyzRiR8K5pWe8KiGPZA/runs/0/artifacts/public/build/target.zip and confirm that it works as expected for you?
Flags: needinfo?(honzab.moz)
(In reply to Andrew Osmond [:aosmond] from comment #7)
> try:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=50603da8ab2babfdf62e560e0b3bbe6780cf249e&selectedJob=2
> 04530849
> 
> I don't have a UPS to test with, although I confirmed with the reference
> machine that we still get WebRender without any battery :). Could you please
> try the debug build from
> https://queue.taskcluster.net/v1/task/I-XJyzRiR8K5pWe8KiGPZA/runs/0/
> artifacts/public/build/target.zip and confirm that it works as expected for
> you?

clean install (not an upgrade) + a clean profile

about:support:

Decision Log
WEBRENDER	
opt-in by default: WebRender is an opt-in feature
blocked by runtime: Qualified enable blocked
WEBRENDER_QUALIFIED	
blocked by env: Has battery

:(
Flags: needinfo?(honzab.moz)
if I find time, I can debug the patch.
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=07d44bab9d48961a308a36bb7bf58900a553bac3

I added some logs that will show up in the about:support page. Hopefully they will shed some light on the matter.
(In reply to Andrew Osmond [:aosmond] from comment #11)
> try:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=07d44bab9d48961a308a36bb7bf58900a553bac3
> 
> I added some logs that will show up in the about:support page. Hopefully
> they will shed some light on the matter.

Failure Log
(#0) Error	[WR-Battery-Check] SetupDiGetDeviceInterfaceDetail(0) 0
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27cb49221d42
Ignore UPS batteries for WebRender qualified purposes. r=jrmuizel
(In reply to Pulsebot from comment #13)
> Pushed by aosmond@gmail.com:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/27cb49221d42
> Ignore UPS batteries for WebRender qualified purposes. r=jrmuizel

I borrowed a UPS and found a small bug in the call sequence. Fixed that and it should work as expected.
https://hg.mozilla.org/mozilla-central/rev/27cb49221d42
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.