Closed
Bug 1490973
Opened 6 years ago
Closed 6 years ago
NS_UnescapeURL calls Append() too much
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
Details
(Keywords: perf)
Attachments
(1 file)
NS_UnescapeURL() perf-sensitive for huge data: URLs. It calls Append() repeatedly and every call check for capacity and aliasing (even though the checks are known to succeed). Also, the zero terminator is written over and over.
|
Assignee | |
Comment 1•6 years ago
|
||
MozReview-Commit-ID: H29SAvXS4Jl
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9008742 [details] Bug 1490973 - Avoid repeatedly calling Append() in NS_UnescapeURL(). Nathan Froyd [:froydnj] has approved the revision.
Attachment #9008742 -
Flags: review+
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4760a22b8b89 Avoid repeatedly calling Append() in NS_UnescapeURL(). r=froydnj
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4760a22b8b89
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•